Merge lite and standard marketplace images#496
Conversation
kspearrin
changed the title
|
Great job! No new security vulnerabilities introduced in this pull request |
vgrassia
left a comment
vgrassia
left a comment
There was a problem hiding this comment.
It looks like the DigitalOcean Packer template needs to be updated to include the new scripts as well.
Bitwarden Claude Code ReviewOverall Assessment: APPROVE This PR merges the separate Lite and Standard marketplace images into a single unified image with an interactive setup wizard that lets users choose the deployment edition on first login. The change deletes three Lite-specific Packer templates, three Lite release workflows, three Lite validation scripts, and the The changes are consistent across all three cloud providers (AWS, Azure, DigitalOcean), file permissions are correctly handled, the release pipeline properly removes the lite workflow dispatches, and no stale references to deleted files remain. Note on prior review: The previous critical finding ("release.yml still dispatches deleted lite workflows") was a false positive. The diff shows those three dispatch steps being removed (lines 542-588 are deletions), which is the correct behavior for this PR. Code Review DetailsNo findings. The implementation is clean and internally consistent. |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
|
4 participants
📔 Objective
Previous design had lite and standard as two separate images being built to host in the marketplace. Azure is the only marketplace that allows multiple "plans" per listing where that model fit. Digital Ocean and AWS would have required multiple listings, which isn't ideal.
This work combines both Standard and Lite editions into one image that a user can select from upon first boot/setup. From there, the install scripts take two different paths. The underlying machine is the same in both cases.