[SHOT-148] fix: syntax error in BUILT_IN_MS_SQL_ENABLED conditional check#492
Merged
keithhubner merged 2 commits intobitwarden:mainfrom Apr 27, 2026
Merged
[SHOT-148] fix: syntax error in BUILT_IN_MS_SQL_ENABLED conditional check#492keithhubner merged 2 commits intobitwarden:mainfrom
keithhubner merged 2 commits intobitwarden:mainfrom
Conversation
|
Thank you for your contribution! We've added this to our internal tracking system for review. Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process. |
keithhubner
previously approved these changes
Apr 20, 2026
|
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
keithhubner
reviewed
Apr 22, 2026
Re-reviewing: the = true check skips the sleep for legacy configs that don't have the key yet (first upgrade only). Suggest != false so the sleep is preserved unless explicitly disabled.
keithhubner
requested changes
Apr 22, 2026
keithhubner
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




🎟️ Tracking
Discovered during automated AWX playbook runs — the unconditional 60-second sleep was causing unnecessary delays on deployments using an external database.
📔 Objective
The
updatebwfunction inrun.shunconditionally sleeps 60 seconds after an update to wait for MSSQL to come online. This is unnecessary for users running an external database. This PR adds a conditional check so the 60-second sleep only occurs whenenable_built_in_ms_sqlis set totrueinconfig.yml. TheBUILT_IN_MS_SQL_ENABLEDvariable is read from the config and used to gate the sleep, matching the pattern already used forenable_key_connector.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes