Skip to content

BRE-609/workflow-changes #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025
Merged

BRE-609/workflow-changes #375

merged 1 commit into from
May 30, 2025

Conversation

mandreko-bitwarden
Copy link
Contributor

🎟️ Tracking

missed as part of original effort for:
https://bitwarden.atlassian.net/browse/BRE-609

📔 Objective

update workflows to be compliant with pull_request_target workflow linter rule ahead of changing rule log level to error

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@mandreko-bitwarden mandreko-bitwarden requested a review from a team as a code owner May 30, 2025 13:08
Copy link

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsc176968f-536d-463a-bb0c-bf5cb8e34791

Great job, no security vulnerabilities found in this Pull Request

@mandreko-bitwarden mandreko-bitwarden merged commit ab98267 into main May 30, 2025
6 checks passed
@mandreko-bitwarden mandreko-bitwarden deleted the bre-609-fix branch May 30, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants