Skip to content

Conversation

@tangowithfoxtrot
Copy link
Contributor

📔 Objective

Update the lock file. This was requested in #1268.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@tangowithfoxtrot tangowithfoxtrot requested a review from a team as a code owner July 1, 2025 18:13
@tangowithfoxtrot tangowithfoxtrot requested a review from Hinton July 1, 2025 18:13
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 1, 2025

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2025

Logo
Checkmarx One – Scan Summary & Details7b35a602-32d9-4418-be26-183ac034e6d9

Great job, no security vulnerabilities found in this Pull Request

@tangowithfoxtrot
Copy link
Contributor Author

RIP. This breaks all the build workflows 😭

@Hinton
Copy link
Member

Hinton commented Jul 3, 2025

We can also just review #1166 right?

The build failures are probably due to pre 1.0 packages containing breaking changes for minor versions. And we should be using version ranges in the Cargo.toml files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants