Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Nov 11, 2024

This PR contains the following updates:

Package Type Update Change
thiserror dependencies major 1.0.57 -> 2.0.0
thiserror dependencies major >=1.0.40, <2.0 -> >=1.0.40, <2.1

Release Notes

dtolnay/thiserror (thiserror)

v2.0.17

Compare Source

  • Use differently named __private module per patch release (#​434)

v2.0.16

Compare Source

  • Add to "no-std" crates.io category (#​429)

v2.0.15

Compare Source

  • Prevent Error::provide API becoming unavailable from a future new compiler lint (#​427)

v2.0.14

Compare Source

  • Allow build-script cleanup failure with NFSv3 output directory to be non-fatal (#​426)

v2.0.13

Compare Source

  • Documentation improvements

v2.0.12

Compare Source

  • Prevent elidable_lifetime_names pedantic clippy lint in generated impl (#​413)

v2.0.11

Compare Source

v2.0.10

Compare Source

  • Support errors containing a generic type parameter's associated type in a field (#​408)

v2.0.9

Compare Source

  • Work around missing_inline_in_public_items clippy restriction being triggered in macro-generated code (#​404)

v2.0.8

Compare Source

  • Improve support for macro-generated derive(Error) call sites (#​399)

v2.0.7

Compare Source

  • Work around conflict with #[deny(clippy::allow_attributes)] (#​397, thanks @​zertosh)

v2.0.6

Compare Source

  • Suppress deprecation warning on generated From impls (#​396)

v2.0.5

Compare Source

  • Prevent deprecation warning on generated impl for deprecated type (#​394)

v2.0.4

Compare Source

v2.0.3

Compare Source

  • Support the same Path field being repeated in both Debug and Display representation in error message (#​383)
  • Improve error message when a format trait used in error message is not implemented by some field (#​384)

v2.0.2

Compare Source

  • Fix hang on invalid input inside #[error(...)] attribute (#​382)

v2.0.1

Compare Source

  • Support errors that contain a dynamically sized final field (#​375)
  • Improve inference of trait bounds for fields that are interpolated multiple times in an error message (#​377)

v2.0.0

Compare Source

Breaking changes

  • Referencing keyword-named fields by a raw identifier like {r#type} inside a format string is no longer accepted; simply use the unraw name like {type} (#​347)

    This aligns thiserror with the standard library's formatting macros, which gained support for implicit argument capture later than the release of this feature in thiserror 1.x.

    #[derive(Error, Debug)]
    #[error("... {type} ...")]  // Before: {r#type}
    pub struct Error {
        pub r#type: Type,
    }
  • Trait bounds are no longer inferred on fields whose value is shadowed by an explicit named argument in a format message (#​345)

    // Before: impl<T: Octal> Display for Error<T>
    // After: impl<T> Display for Error<T>
    #[derive(Error, Debug)]
    #[error("{thing:o}", thing = "...")]
    pub struct Error<T> {
        thing: T,
    }
  • Tuple structs and tuple variants can no longer use numerical {0} {1} access at the same time as supplying extra positional arguments for a format message, as this makes it ambiguous whether the number refers to a tuple field vs a different positional arg (#​354)

    #[derive(Error, Debug)]
    #[error("ambiguous: {0} {}", $N)]
    //                  ^^^ Not allowed, use #[error("... {0} {n}", n = $N)]
    pub struct TupleError(i32);
  • Code containing invocations of thiserror's derive(Error) must now have a direct dependency on the thiserror crate regardless of the error data structure's contents (#​368, #​369, #​370, #​372)

Features

  • Support disabling thiserror's standard library dependency by disabling the default "std" Cargo feature: thiserror = { version = "2", default-features = false } (#​373)

  • Support using r#source as field name to opt out of a field named "source" being treated as an error's Error::source() (#​350)

    #[derive(Error, Debug)]
    #[error("{source} ==> {destination}")]
    pub struct Error {
        r#source: char,
        destination: char,
    }
    
    let error = Error { source: 'S', destination: 'D' };
  • Infinite recursion in a generated Display impl now produces an unconditional_recursion warning (#​359)

    #[derive(Error, Debug)]
    #[error("??? {self}")]
    pub struct Error;
  • A new attribute #[error(fmt = path::to::myfmt)] can be used to write formatting logic for an enum variant out-of-line (#​367)

    #[derive(Error, Debug)]
    pub enum Error {
        #[error(fmt = demo_fmt)]
        Demo { code: u16, message: Option<String> },
    }
    
    fn demo_fmt(code: &u16, message: &Option<String>, formatter: &mut fmt::Formatter) -> fmt::Result {
        write!(formatter, "{code}")?;
        if let Some(msg) = message {
            write!(formatter, " - {msg}")?;
        }
        Ok(())
    }
  • Enums with an enum-level format message are now able to have individual variants that are transparent to supersede the enum-level message (#​366)

    #[derive(Error, Debug)]
    #[error("my error {0}")]
    pub enum Error {
        Json(#[from] serde_json::Error),
        Yaml(#[from] serde_yaml::Error),
        #[error(transparent)]
        Other(#[from] anyhow::Error),
    }

Configuration

📅 Schedule: Branch creation - "every 2nd week starting on the 2 week of the year before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate
Copy link
Contributor Author

renovate bot commented Nov 11, 2024

⚠️ Artifact update problem

Renovate failed to update artifacts related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: Cargo.lock
Command failed: cargo update --config net.git-fetch-with-cli=true --manifest-path crates/bitwarden/Cargo.toml --package [email protected] --precise 2.0.17
    Updating git repository `https://github.com/bitwarden/sdk-internal.git`
From https://github.com/bitwarden/sdk-internal
 * [new ref]           ab7ae369f07ecbcce8db5512f076881ff8cc8f7b -> refs/commit/ab7ae369f07ecbcce8db5512f076881ff8cc8f7b
    Updating crates.io index
error: failed to select a version for the requirement `thiserror = "^1.0.20"`
candidate versions found which didn't match: 2.0.17
location searched: crates.io index
required by package `jni v0.21.1`
    ... which satisfies dependency `jni = "^0.21"` (locked to 0.21.1) of package `rustls-platform-verifier v0.6.2`
    ... which satisfies dependency `rustls-platform-verifier = "^0.6.0"` (locked to 0.6.2) of package `bitwarden-core v1.0.0 (https://github.com/bitwarden/sdk-internal.git?rev=ab7ae369f07ecbcce8db5512f076881ff8cc8f7b#ab7ae369)`
    ... which satisfies git dependency `bitwarden-core` (locked to 1.0.0) of package `bitwarden v1.0.0 (/tmp/renovate/repos/github/bitwarden/sdk-sm/crates/bitwarden)`
    ... which satisfies path dependency `bitwarden` (locked to 1.0.0) of package `bws v1.0.0 (/tmp/renovate/repos/github/bitwarden/sdk-sm/crates/bws)`

File name: Cargo.lock
Command failed: cargo update --config net.git-fetch-with-cli=true --manifest-path crates/bws/Cargo.toml --package [email protected] --precise 2.0.17
    Updating crates.io index
error: failed to select a version for the requirement `thiserror = "^1.0.20"`
candidate versions found which didn't match: 2.0.17
location searched: crates.io index
required by package `jni v0.21.1`
    ... which satisfies dependency `jni = "^0.21"` (locked to 0.21.1) of package `rustls-platform-verifier v0.6.2`
    ... which satisfies dependency `rustls-platform-verifier = "^0.6.0"` (locked to 0.6.2) of package `bitwarden-core v1.0.0 (https://github.com/bitwarden/sdk-internal.git?rev=ab7ae369f07ecbcce8db5512f076881ff8cc8f7b#ab7ae369)`
    ... which satisfies git dependency `bitwarden-core` (locked to 1.0.0) of package `bitwarden v1.0.0 (/tmp/renovate/repos/github/bitwarden/sdk-sm/crates/bitwarden)`
    ... which satisfies path dependency `bitwarden` (locked to 1.0.0) of package `bws v1.0.0 (/tmp/renovate/repos/github/bitwarden/sdk-sm/crates/bws)`

@bitwarden-bot bitwarden-bot changed the title [deps]: Update Rust crate thiserror to v2 [PM-14693] [deps]: Update Rust crate thiserror to v2 Nov 11, 2024
@bitwarden-bot
Copy link

Internal tracking:

@codecov
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 15.34%. Comparing base (0463301) to head (661d100).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1174   +/-   ##
=======================================
  Coverage   15.34%   15.34%           
=======================================
  Files          21       21           
  Lines        1199     1199           
=======================================
  Hits          184      184           
  Misses       1015     1015           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@renovate renovate bot changed the title [PM-14693] [deps]: Update Rust crate thiserror to v2 [deps]: Update Rust crate thiserror to v2 Nov 11, 2024
@renovate renovate bot force-pushed the renovate/thiserror-2.x branch from 980ad9d to 9da2708 Compare November 17, 2024 16:39
@renovate renovate bot force-pushed the renovate/thiserror-2.x branch from 9da2708 to a3cb11a Compare July 31, 2025 18:40
@renovate renovate bot requested a review from a team as a code owner July 31, 2025 18:40
@renovate renovate bot force-pushed the renovate/thiserror-2.x branch from a3cb11a to 93d7240 Compare August 23, 2025 18:51
@renovate renovate bot force-pushed the renovate/thiserror-2.x branch 2 times, most recently from faf64a7 to 0df5e41 Compare September 29, 2025 19:40
@renovate renovate bot force-pushed the renovate/thiserror-2.x branch from 0df5e41 to 2daa073 Compare October 6, 2025 02:42
@vincentsalucci
Copy link
Member

New Jira tracking task: https://bitwarden.atlassian.net/browse/SM-1711

@renovate renovate bot force-pushed the renovate/thiserror-2.x branch from 9562cc3 to 661d100 Compare December 4, 2025 17:11
@tangowithfoxtrot tangowithfoxtrot enabled auto-merge (squash) December 4, 2025 17:34
@tangowithfoxtrot tangowithfoxtrot enabled auto-merge (squash) December 8, 2025 15:52
@tangowithfoxtrot tangowithfoxtrot merged commit a3b5737 into main Dec 8, 2025
103 of 106 checks passed
@tangowithfoxtrot tangowithfoxtrot deleted the renovate/thiserror-2.x branch December 8, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants