-
Notifications
You must be signed in to change notification settings - Fork 24
[PM-29492] API middleware support #699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Great job! No new security vulnerabilities introduced in this pull request |
🔍 SDK Breaking Change Detection ResultsSDK Version:
Breaking change detection completed. View SDK workflow |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #699 +/- ##
=======================================
Coverage 79.40% 79.40%
=======================================
Files 293 293
Lines 32390 32395 +5
=======================================
+ Hits 25718 25722 +4
- Misses 6672 6673 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
quexten
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving for KM-owned code.
coroiu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to see that we were able to use an existing solution!
# Conflicts: # support/generate-api-bindings-ci.sh
|
Had to fix conflicts on the scripts due to #660 |

🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-29492
📔 Objective
Add support for API middleware for the autogenerated API crates. This would allow us to add middlewares that inspect and modify the request and response, or that retry the requests. It seems very flexible and I think it should cover all our use cases. Note that the version of reqwest-middleware is not the latest, as it needs to match with a specific reqwest version, and the next major reqwest version requires some rework around rustls-platform-verifier.
Note that this is doesn't add any middleware yet, but here's an example of how one would look:
🚨 Breaking Changes
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes