Skip to content

[PM-23712] Migrate remaining folder domain to SDK #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Jul 1, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-23712

📔 Objective

Fully migrate folder create and edit to the SDK to demonstrate the repository and api capabilities.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Jul 1, 2025

Logo
Checkmarx One – Scan Summary & Detailse14e87aa-2faa-4b0f-adae-9a04bf25e4ef

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jul 1, 2025

Codecov Report

Attention: Patch coverage is 74.25743% with 104 lines in your changes missing coverage. Please review.

Project coverage is 72.11%. Comparing base (81493f3) to head (76120be).

Files with missing lines Patch % Lines
crates/bitwarden-vault/src/folder/folder_client.rs 0.00% 58 Missing ⚠️
crates/bitwarden-vault/src/folder/get_list.rs 0.00% 20 Missing ⚠️
crates/bitwarden-test/src/repository.rs 57.14% 15 Missing ⚠️
crates/bitwarden-vault/src/folder/folder_models.rs 0.00% 5 Missing ⚠️
crates/bitwarden-wasm-internal/src/platform/mod.rs 0.00% 4 Missing ⚠️
crates/bitwarden-vault/src/folder/create.rs 99.13% 1 Missing ⚠️
crates/bitwarden-vault/src/folder/edit.rs 99.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #340      +/-   ##
==========================================
+ Coverage   71.86%   72.11%   +0.25%     
==========================================
  Files         240      245       +5     
  Lines       19635    20024     +389     
==========================================
+ Hits        14111    14441     +330     
- Misses       5524     5583      +59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Base automatically changed from arch/client-managed-tokens to main July 3, 2025 07:56
@Hinton Hinton marked this pull request as ready for review July 3, 2025 12:17
@Hinton Hinton requested review from a team as code owners July 3, 2025 12:17
Copy link
Member

@dani-garcia dani-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me, just some small comments

@Hinton Hinton requested a review from dani-garcia July 7, 2025 09:24
dani-garcia
dani-garcia previously approved these changes Jul 7, 2025
@Hinton Hinton changed the title Migrate folder create and edit Migrate remaining folder domain to SDK Jul 11, 2025
@Hinton Hinton requested a review from dani-garcia July 11, 2025 10:18
@Hinton Hinton changed the title Migrate remaining folder domain to SDK [PM-23712] Migrate remaining folder domain to SDK Jul 11, 2025
…lder

# Conflicts:
#	crates/bitwarden-vault/Cargo.toml
Copy link

Copy link
Contributor

@addisonbeck addisonbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants