Skip to content

Remove vault folder from wasm-internal #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 28, 2025

Move totp

3dba619
Select commit
Loading
Failed to load commit list.
Merged

Remove vault folder from wasm-internal #294

Move totp
3dba619
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 27, 2025 in 0s

70.28% (+0.07%) compared to 3d2e4b5

View this Pull Request on Codecov

70.28% (+0.07%) compared to 3d2e4b5

Details

Codecov Report

Attention: Patch coverage is 40.00000% with 27 lines in your changes missing coverage. Please review.

Project coverage is 70.28%. Comparing base (3d2e4b5) to head (3dba619).

Files with missing lines Patch % Lines
crates/bitwarden-vault/src/vault_client.rs 33.33% 10 Missing ⚠️
crates/bitwarden-vault/src/totp_client.rs 0.00% 9 Missing ⚠️
crates/bitwarden-uniffi/src/vault/mod.rs 0.00% 6 Missing ⚠️
...es/bitwarden-vault/src/cipher/attachment_client.rs 92.85% 1 Missing ⚠️
crates/bitwarden-wasm-internal/src/client.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #294      +/-   ##
==========================================
+ Coverage   70.20%   70.28%   +0.07%     
==========================================
  Files         220      217       -3     
  Lines       17009    16990      -19     
==========================================
  Hits        11942    11942              
+ Misses       5067     5048      -19

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov