[PM-21902] Migrate back to tsify #284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #284 +/- ##
==========================================
+ Coverage 71.85% 71.86% +0.01%
==========================================
Files 240 240
Lines 19635 19635
==========================================
+ Hits 14108 14111 +3
+ Misses 5527 5524 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hinton
reviewed
May 23, 2025
# Conflicts: # Cargo.lock # crates/bitwarden-vault/Cargo.toml
Hinton
previously approved these changes
May 29, 2025
# Conflicts: # crates/bitwarden-exporters/Cargo.toml # crates/bitwarden-generators/Cargo.toml # crates/bitwarden-vault/Cargo.toml
# Conflicts: # crates/bitwarden-core/Cargo.toml # crates/bitwarden-ipc/Cargo.toml # crates/bitwarden-threading/Cargo.toml
quexten
previously approved these changes
Jun 23, 2025
addisonbeck
previously approved these changes
Jun 24, 2025
# Conflicts: # Cargo.lock # crates/bitwarden-ipc/Cargo.toml
|
quexten
approved these changes
Jul 10, 2025
Hinton
approved these changes
Jul 11, 2025
gbubemismith
approved these changes
Jul 11, 2025
justindbaur
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-21902
📔 Objective
Migrate back to tsify from tsify-next now that the original is back to being maintained and all the changes have been backported.
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes