Skip to content

Conversation

@aj-bw
Copy link
Member

@aj-bw aj-bw commented May 7, 2025

🎟️ Tracking

BRE-609

📔 Objective

update workflows to be compliant with pull_request_target workflow linter rule ahead of changing rule log level to error

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2025

Logo
Checkmarx One – Scan Summary & Details48a4b703-fd7b-4d46-b652-c8559c738a31

Great job, no security vulnerabilities found in this Pull Request

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 7, 2025

@codecov
Copy link

codecov bot commented May 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.56%. Comparing base (90c331a) to head (81e10eb).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #266   +/-   ##
=======================================
  Coverage   69.56%   69.56%           
=======================================
  Files         213      213           
  Lines       16644    16644           
=======================================
  Hits        11578    11578           
  Misses       5066     5066           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aj-bw aj-bw marked this pull request as ready for review May 13, 2025 16:02
@aj-bw aj-bw requested a review from a team as a code owner May 13, 2025 16:02
@aj-bw aj-bw requested a review from tangowithfoxtrot May 13, 2025 16:02
@aj-bw aj-bw merged commit 9502e4e into main May 16, 2025
43 checks passed
@aj-bw aj-bw deleted the BRE-609/workflow-changes branch May 16, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants