Skip to content

[PM-20615] Only process incoming messages once #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 42 commits into from
Jun 11, 2025
Merged
Changes from all commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
84c41d6
fix: unexposed IPC function
coroiu May 5, 2025
9a284bc
feat: make communication backend Send + Sync
coroiu Apr 29, 2025
987c399
refactor: make session a regular generic variable
coroiu Apr 29, 2025
488840b
feat: make session repository Send + Sync
coroiu Apr 29, 2025
42e50cc
feat: make crypto provider Send + Sync
coroiu Apr 29, 2025
25ad14c
fix: make com::subscribe send + sync
coroiu Apr 29, 2025
4779ddc
feat: implement a receiver thread in IpcClient
coroiu Apr 30, 2025
c7687ae
fix: adapt tests and errors to new receive method
coroiu Apr 30, 2025
8aa7ee7
refactor: simplify errors
coroiu Apr 30, 2025
6eb2d55
feat: use constant for channel buffer capacity
coroiu Apr 30, 2025
781f36f
fix: build issue
coroiu Apr 30, 2025
2791902
chore: clean up old code
coroiu Apr 30, 2025
75124a1
feat: expose start function
coroiu Apr 30, 2025
36664aa
feat: expose is_running
coroiu Apr 30, 2025
b332cdb
wip: make ipc client WASM compatible
coroiu Apr 30, 2025
7b84ee1
fix: tests and wasm thread spawning
coroiu May 6, 2025
2114002
fix: most linting
coroiu May 6, 2025
71573d1
refactor: replace Arc with Rc
coroiu May 6, 2025
b3d8cb4
fix: woops, fix wrong assertions
coroiu May 6, 2025
d946697
chore: simplify dropping
coroiu May 19, 2025
75c52cc
chore: clean up comment
coroiu May 19, 2025
42d9fc8
chore: refactor to not use `Into`
coroiu May 19, 2025
7a7e71a
feat: simplify initialization
coroiu May 21, 2025
72d2d24
Merge branch 'main' into PM-20615-only-process-incoming-messages-once
coroiu May 21, 2025
0c30275
feat: convert communication backend to use runner
coroiu May 20, 2025
588983b
feat: improve docs
coroiu May 20, 2025
cac4a0e
feat: improve docs
coroiu May 20, 2025
76f902c
feat: add tokio-util crate
coroiu May 21, 2025
db1b0dd
fix: remove unnecessary question mark
coroiu May 23, 2025
1a03979
Merge branch 'main' into PM-20615-only-process-incoming-messages-once
coroiu May 26, 2025
a79b6e1
feat: replace timeout with cancellation token
coroiu May 27, 2025
824dc28
feat: add Debug trait to errors
coroiu May 27, 2025
47582bc
feat: simplify subscriptions
coroiu May 27, 2025
78b3c4c
fix: linting
coroiu May 27, 2025
486b324
feat: replace cancellation_handle with token
coroiu May 27, 2025
b259c00
fix: lint
coroiu May 27, 2025
8ba4166
feat: address PR feedback
coroiu May 28, 2025
cef8df6
Merge branch 'main' into PM-20615-only-process-incoming-messages-once
coroiu Jun 10, 2025
048da10
chore: add some more docs
coroiu Jun 10, 2025
c975f2c
Merge branch 'main' into PM-20615-only-process-incoming-messages-once
coroiu Jun 10, 2025
1c4b5e5
fix: lint
coroiu Jun 10, 2025
a439d83
fix: lint
coroiu Jun 11, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 49 additions & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions crates/bitwarden-ipc/Cargo.toml
Original file line number Diff line number Diff line change
@@ -15,22 +15,22 @@ wasm = [
"dep:wasm-bindgen",
"dep:wasm-bindgen-futures",
"dep:js-sys",
"bitwarden-error/wasm"
"bitwarden-error/wasm",
"bitwarden-threading/wasm"
] # WASM support

[dependencies]
bitwarden-error = { workspace = true }
bitwarden-threading = { workspace = true }
js-sys = { workspace = true, optional = true }
log = { workspace = true }
serde = { workspace = true }
serde_json = { workspace = true }
thiserror = { workspace = true }
tokio = { features = ["sync", "time"], workspace = true }
tokio = { features = ["sync", "time", "rt"], workspace = true }
tsify-next = { workspace = true, optional = true }
wasm-bindgen = { workspace = true, optional = true }
wasm-bindgen-futures = { workspace = true, optional = true }

[dev-dependencies]
tokio = { workspace = true, features = ["rt"] }

[lints]
workspace = true
1 change: 1 addition & 0 deletions crates/bitwarden-ipc/src/constants.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
pub(super) const CHANNEL_BUFFER_CAPACITY: usize = 50;
49 changes: 0 additions & 49 deletions crates/bitwarden-ipc/src/error.rs

This file was deleted.

Loading