Format WASM generator code to be in line with other clients #223
Conversation
|
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #223 +/- ##
==========================================
+ Coverage 68.92% 68.98% +0.05%
==========================================
Files 212 211 -1
Lines 16126 16112 -14
==========================================
Hits 11115 11115
+ Misses 5011 4997 -14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
suggestion: We're working towards removing the duplicate clients from |
There was a problem hiding this comment.
I think we should follow the pattern established in https://github.com/bitwarden/sdk-internal/pull/222/files#diff-6cb7ede8c0bc3e55eae30c471bb8f5d2bc385e50d08a604d5855f80a46d7317dR57 and remove generators.rs from wasm-internal and add wasm_bindgen to the generators crate.
Just updated! Thanks for the heads up on the new pattern! |
There was a problem hiding this comment.
I think this is missing the wasm-bindgen-futures = { workspace = true, optional = true } dependency in the bitwarden-generators crate, which is why CI is failing.
This dependency is not used directly by us, but by the code generated by #[cfg_attr(feature = "wasm", wasm_bindgen)] when some functions are async.
|
## 🎟️ Tracking <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> ## 📔 Objective Fixes: errors introduced by #223 ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes
🎟️ Tracking
📔 Objective
Reformatting some of my previous PR to be more in line with the rest of the code
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes