-
Notifications
You must be signed in to change notification settings - Fork 12
[PM-20361] Signature keys #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 16 commits
Commits
Show all changes
155 commits
Select commit
Hold shift + click to select a range
c9b80df
Implement signing keys and signing
quexten 2ad9f59
Remove unused code
quexten b0c3dae
Add test vector
quexten 2e8bd92
Cargo fmt
quexten f7f1e2e
Make ed25519 dependency version a range
quexten 6deb284
Add signed object
quexten f42f719
Merge branch 'main' into km/cose-signatures
quexten 61496cc
Merge branch 'main' into km/cose-signatures
quexten 8354476
Replace magic value
quexten 04d5329
Clean up crate::error reference
quexten efd23cc
Add comments to signing and verifying key
quexten d6737cf
Move and clarify comment, drop optional verifying key from signing key
quexten d2b829b
Change comment into docs
quexten 9484a64
Move signature errors to separate enum
quexten 7e39e9c
Update test vectors
quexten a37f3e1
Format
quexten e1642b6
[PM-20361] Expose signing key generation to mobile and wasm clients &โฆ
quexten 6c725d2
Remove incorrect login response change
quexten fc895d8
Fix comment
quexten 0e33fee
Cleanup
quexten 6308cc5
Add comments
quexten 971eb17
Cleanup
quexten 12387f8
Remove unrelated change
quexten f3eb525
Cleanup
quexten d6bbae0
Fix init
quexten 2ab6620
Cleanup
quexten 17e0a07
Fix sorting of dependencies
quexten 8c9f00f
Attempt to fix build
quexten 06b26ba
Add more default nil values for signing key to fix ios build
quexten a2e95e7
Fix docs
quexten e6ab5ef
Fix build
quexten 4842309
Fix doc
quexten 0e3bcb6
Merge branch 'main' into km/cose-signatures
quexten d6e6e99
Add tests to purecrypto
quexten 0578743
Remove code to make test vectors
quexten 4182ad4
Merge branch 'km/cose-signatures' of github.com:bitwarden/sdk-internaโฆ
quexten 38ec3eb
Cleanup
quexten 4467b0d
Fix docs
quexten e373638
Merge branch 'main' into km/cose-signatures
quexten d17399d
Split up and simplify
quexten 26bf715
Undo renames
quexten 5846dbc
Undo changes
quexten d466ec7
Add examples
quexten b27ddf4
Cargo fmt
quexten 5733baa
Fix build
quexten beb1251
Add comment
quexten af72a87
Address formatting issue
quexten bf9bea2
Merge branch 'main' into km/cose-signatures
quexten f18512c
Fix build
quexten 17f8d09
Add signed public key test
quexten a8c6fa5
Cleanup
quexten 55ddd0b
Add comment
quexten 053d894
Cargo fmt
quexten c520046
Cleanup
quexten 740584a
Cleanup
quexten 621374d
Move in deprecated annotation
quexten d9c224b
Remove allow
quexten 7717633
Cleanup
quexten 6d8db7c
Clean up comment
quexten 1236426
Cargo fmt
quexten ec2b153
Remove zeroize and pin signing key
quexten b738834
Fix build and impl zeroizeOnDrop for signingkey
quexten 863ba33
Remove unused error
quexten 8e61453
Add comment with link to follow-up task
quexten 0bd07ce
Remove unnecessary pub(self)
quexten 6475c07
Merge branch 'main' into km/cose-signatures
quexten 6775415
Remove empty line
quexten 82c7090
Remove another newline
quexten e705d28
Replace OsRng with threadrng
quexten 632f74e
Add match to signed public key
quexten 3b567bc
Replace OsRng with threadrng
quexten 7a0b358
Add finegrained encoding errors
quexten 36df567
Apply clippy fixes
quexten d378933
Clean up error
quexten 0c042be
Update crates/bitwarden-crypto/src/signing/verifying_key.rs
quexten 37436d4
Update crates/bitwarden-crypto/src/signing/verifying_key.rs
quexten 594f0f1
Update crates/bitwarden-crypto/src/keys/signed_public_key.rs
quexten 67b9757
Add docs
quexten 2344cc3
Merge branch 'km/cose-signatures' of github.com:bitwarden/sdk-internaโฆ
quexten bf91eff
Move test message into test module
quexten a1a2975
Fix build
quexten cd84ab7
Cargo fmt
quexten 4b26c43
Add documentation
quexten 3f9e087
Update crates/bitwarden-crypto/src/signing/signed_object.rs
quexten 9c008fd
Update crates/bitwarden-core/src/mobile/crypto.rs
quexten eb5e183
Update crates/bitwarden-crypto/src/signing/signature.rs
quexten fa8f8e6
Update crates/bitwarden-crypto/src/signing/signed_object.rs
quexten dd6ad41
Update crates/bitwarden-crypto/src/signing/namespace.rs
quexten 2d7346b
Change signing key to encstring
quexten a0b58fb
Merge branch 'km/cose-signatures' of github.com:bitwarden/sdk-internaโฆ
quexten 6d9e067
Add docs
quexten 29da0d8
Add docs
quexten 7439bb1
Add docs
quexten f2c0991
Add docs
quexten 8f6168b
Add docs
quexten 0570982
Format
quexten 351ccf4
Update crates/bitwarden-crypto/src/signing/signature.rs
quexten aaacfbc
Add docs
quexten 21949fb
Merge branch 'km/cose-signatures' of github.com:bitwarden/sdk-internaโฆ
quexten 4f1c505
Add docs
quexten b1a1176
Add signed org memberships / emergency access
quexten 88145cf
Add docs
quexten 4635bc6
Apply suggestion to clean up from_cose
quexten ff59f80
Apply suggestion to rewrite from_cose in verifying_key
quexten 16914c3
Merge branch 'main' into km/cose-signatures
quexten b726fb4
Fix build
quexten 36cb017
Fix build
quexten f640374
Fix doc formatting
quexten d73818c
Fix typo
quexten 626557f
Fix testvector
quexten e11ff9a
Fix clippy error
quexten ac72887
Update crates/bitwarden-crypto/src/signing/cose.rs
quexten 91723f7
Cleanup and expose SignedPublicKey object publically
quexten b547183
Merge branch 'km/cose-signatures' of github.com:bitwarden/sdk-internaโฆ
quexten 893624f
Fix build
quexten ca2ab02
Fix build
quexten 072bbf6
Expose signed public key publically
quexten 68debad
Clippy cleanup
quexten 830de67
Improve message.rs comment
quexten 762057b
Merge branch 'main' into km/cose-signatures
quexten 03a67ff
Rename to make_user_signing_keys_for_enrollment
quexten 228c1c4
Merge branch 'km/cose-signatures' of github.com:bitwarden/sdk-internaโฆ
quexten 4f414fd
Impl try from i128
quexten 6706109
Cleanup
quexten 1bc09fb
Cargo fmt
quexten cedf2e4
Cleanup
quexten bbd247a
Update crates/bitwarden-crypto/src/signing/signed_object.rs
quexten 88dadac
Update crates/bitwarden-crypto/src/signing/signed_object.rs
quexten a73516c
Update crates/bitwarden-crypto/src/signing/signature.rs
quexten 04b1380
Delete unused method
quexten 29cf679
Remove allow unused
quexten 30252c3
Apply nit
quexten bb2bdae
Drop renames on signed public key format
quexten 5e5ef60
Remove example namespaces
quexten 277d76a
Re-add example namespaces for test modules
quexten 4322f3d
Fix build
quexten 439b254
Fix tests
quexten 84342f6
Cargo fmt
quexten 09a30b1
Merge branch 'main' into km/cose-signatures
quexten 444eb77
Merge branch 'main' into km/cose-signatures
quexten 8a8bc06
Update crates/bitwarden-crypto/src/signing/namespace.rs
quexten d5cbedb
Use new encrypt api to avoid deprecated key access
quexten f3e5f42
Fix clippy warnings for examples
quexten 33947c9
Merge branch 'km/cose-signatures' of github.com:bitwarden/sdk-internaโฆ
quexten d4147f2
Add comment
quexten 2a063f0
Remove unnecessary variant in macro
quexten 46386be
Change make signing key to return self instead of result
quexten 6a9b8fe
Remove duplicate from str/tryfrom impl
quexten 59a8cba
Deduplicate public key encryption algorithms
quexten cb5ef04
Update comment for signing key
quexten 9d555c6
Fix cargo doc errors
quexten 6be2169
Update crates/bitwarden-crypto/src/keys/signed_public_key.rs
quexten 3655e39
Merge branch 'main' into km/cose-signatures
quexten 0bf904c
Fix cargo doc
quexten 9fc8fc9
Remove backticks in docs for bytebuf
quexten File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.