-
Notifications
You must be signed in to change notification settings - Fork 10
[PM-20361] Signature keys #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 16 commits
c9b80df
2ad9f59
b0c3dae
2e8bd92
f7f1e2e
6deb284
f42f719
61496cc
8354476
04d5329
efd23cc
d6737cf
d2b829b
9484a64
7e39e9c
a37f3e1
e1642b6
6c725d2
fc895d8
0e33fee
6308cc5
971eb17
12387f8
f3eb525
d6bbae0
2ab6620
17e0a07
8c9f00f
06b26ba
a2e95e7
e6ab5ef
4842309
0e3bcb6
d6e6e99
0578743
4182ad4
38ec3eb
4467b0d
e373638
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,6 +14,7 @@ mod asymmetric_crypto_key; | |
pub use asymmetric_crypto_key::{ | ||
AsymmetricCryptoKey, AsymmetricEncryptable, AsymmetricPublicCryptoKey, | ||
}; | ||
mod signing_crypto_key; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. issue: The key namespace is getting crowed. I think we need to separate cryptographic keys (asymmetric, symmetric) from Bitwarden concepts like user, master keys. I'm not sure where signing keys falls here? It might be beneficial to tie the keys to the enc string implementations? This doesn't block this PR but I'd want us to figure this out before adding more files to crypto. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I agree. I've been meaning to both look at simplifying some bitwarden-crypto interfaces, but cleaning up some concepts here, but on my priority lists that's after getting cose symmetric crypto + (user) signing done. MasterKey, PinKey, etc. are just specially named SymmetricKeys. So I feel that the bitwarden labeled concepts, should be separated from the "pure" crypto concepts. |
||
mod user_key; | ||
pub use user_key::UserKey; | ||
mod device_key; | ||
|
@@ -26,6 +27,5 @@ pub use kdf::{ | |
default_argon2_iterations, default_argon2_memory, default_argon2_parallelism, | ||
default_pbkdf2_iterations, Kdf, | ||
}; | ||
#[cfg(test)] | ||
pub(crate) use key_id::KEY_ID_SIZE; | ||
mod utils; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.