Skip to content

BRE-403 - Update CI Secret Name #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Conversation

vgrassia
Copy link
Member

🎟️ Tracking

📔 Objective

This PR updates the CI secret name in workflows from AZURE_CI_SERVICE_PRINCIPAL to AZURE_KV_CI_SERVICE_PRINCIPAL so we don't have a duplicate repository secret.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@vgrassia vgrassia requested a review from a team October 31, 2024 13:35
@vgrassia vgrassia self-assigned this Oct 31, 2024
@vgrassia vgrassia enabled auto-merge (squash) October 31, 2024 13:35
@vgrassia vgrassia disabled auto-merge October 31, 2024 13:35
@vgrassia vgrassia requested a review from Hinton October 31, 2024 13:37
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.85%. Comparing base (5905354) to head (f777e48).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #18   +/-   ##
=======================================
  Coverage   62.85%   62.85%           
=======================================
  Files         179      179           
  Lines       12688    12688           
=======================================
  Hits         7975     7975           
  Misses       4713     4713           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vgrassia vgrassia removed the request for review from Hinton October 31, 2024 14:02
@vgrassia vgrassia enabled auto-merge (squash) October 31, 2024 14:08
@vgrassia vgrassia merged commit c8de276 into main Oct 31, 2024
38 checks passed
@vgrassia vgrassia deleted the bre-403_update-secret-names branch October 31, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants