Skip to content

[PM-17984] Remove AES128-CBC+HMAC encryption #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 6, 2025

Conversation

quexten
Copy link
Contributor

@quexten quexten commented Feb 6, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-17984

📔 Objective

Removes AES128-CBC-HMAC encryption. This type was never actually used, and makes it impossible to uniquely determine the key type, since keys are currently just typed by size, and this has the same size as type 0 keys.

Blocks: #127

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@quexten quexten changed the title Remove AES128CBC-HMAC encryption [PM-17984] Remove AES128CBC-HMAC encryption Feb 6, 2025
Copy link
Contributor

github-actions bot commented Feb 6, 2025

Logo
Checkmarx One – Scan Summary & Details4e073630-966e-4da5-85cc-f2f039638b0a

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.41%. Comparing base (00ffa38) to head (00f12e2).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
- Coverage   65.70%   65.41%   -0.30%     
==========================================
  Files         194      194              
  Lines       14930    14875      -55     
==========================================
- Hits         9810     9730      -80     
- Misses       5120     5145      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@quexten quexten marked this pull request as ready for review February 6, 2025 11:49
@quexten quexten changed the title [PM-17984] Remove AES128CBC-HMAC encryption [PM-17984] Remove AES128-CBC+HMAC encryption Feb 6, 2025
@Hinton Hinton requested review from Hinton and dani-garcia February 6, 2025 12:27
Copy link
Member

@Hinton Hinton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does what it claims to do which is removing AesCbc128_HmacSha256_B64

Copy link
Member

@dani-garcia dani-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this should be able to me merged without conflicting on #8

@quexten quexten merged commit c89ea8e into main Feb 6, 2025
40 checks passed
@quexten quexten deleted the km/pm-17984/remove-cbc128hmac branch February 6, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants