-
Notifications
You must be signed in to change notification settings - Fork 10
[PM-17984] Remove AES128-CBC+HMAC encryption #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #147 +/- ##
==========================================
- Coverage 65.70% 65.41% -0.30%
==========================================
Files 194 194
Lines 14930 14875 -55
==========================================
- Hits 9810 9730 -80
- Misses 5120 5145 +25 ☔ View full report in Codecov by Sentry. |
…sdk-internal into km/pm-17984/remove-cbc128hmac
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does what it claims to do which is removing AesCbc128_HmacSha256_B64
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, this should be able to me merged without conflicting on #8
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-17984
📔 Objective
Removes AES128-CBC-HMAC encryption. This type was never actually used, and makes it impossible to uniquely determine the key type, since keys are currently just typed by size, and this has the same size as type 0 keys.
Blocks: #127
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes