Skip to content

refactor(vault)!: replace attachmentview with attachmentfullview - #1289

Closed
quexten wants to merge 1 commit into
cipher-full-view-part-3from
cipher-full-view-part-4
Closed

refactor(vault)!: replace attachmentview with attachmentfullview#1289
quexten wants to merge 1 commit into
cipher-full-view-part-3from
cipher-full-view-part-4

Conversation

@quexten

@quexten quexten commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

🎟️ Tracking

📔 Objective

🚨 Breaking Changes


Stack created with GitHub Stacks CLIGive Feedback 💬

@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

🔍 SDK Breaking Change Detection

SDK Version: cipher-full-view-part-4 (2044a11)

⚠️ If breaking changes are detected, a corresponding pull request addressing them must be ready for merge in the affected client repository.

Client Status Details
android ❌ Breaking changes detected Compilation failed with new SDK version. A corresponding pull request addressing the breaking changes must be ready for merge in bitwarden/android. - View Details

Breaking change detection uses the build of the SDK from this branch, including any incompatibities pre-existing on or merged into this branch. Check the workflow logs to confirm.
Results update as workflows complete.

@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.95402% with 7 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (cipher-full-view-part-3@7da83fc). Learn more about missing BASE report.

Files with missing lines Patch % Lines
crates/bitwarden-uniffi/src/vault/attachments.rs 0.00% 4 Missing ⚠️
...itwarden-vault/src/cipher/attachment_client/mod.rs 25.00% 3 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##             cipher-full-view-part-3    #1289   +/-   ##
==========================================================
  Coverage                           ?   85.76%           
==========================================================
  Files                              ?      483           
  Lines                              ?    68321           
  Branches                           ?        0           
==========================================================
  Hits                               ?    58596           
  Misses                             ?     9725           
  Partials                           ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@quexten
quexten force-pushed the cipher-full-view-part-4 branch from 2044a11 to 39f49d0 Compare July 22, 2026 11:39
Copilot AI review requested due to automatic review settings July 22, 2026 11:39

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@quexten quexten closed this Jul 23, 2026
An error occurred while trying to automatically change base from cipher-full-view-part-3 to main July 30, 2026 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants