Ac/pm 38906 decrypt list with failures for collections - #1253
Conversation
- Added `DecryptCollectionListResult` struct to encapsulate successful and failed decryption results of collections. - Introduced `decrypt_list_with_failures` method in `CollectionsClient` to return both successfully decrypted collections and those that failed, improving error handling during decryption. - Updated `Collection` struct to derive `Clone` for better usability in collection operations.
- Introduced three new test cases for the `decrypt_list_with_failures` method in the `CollectionsClient`. - The tests cover scenarios for all successful decryption, mixed results with one failure, and an empty collection list. - These additions enhance the test coverage for error handling during collection decryption, ensuring robustness in the implementation.
…ist-with-failures-for-collections
…bitwarden-vault` - Implemented tests to compare the performance of sequential versus bulk decryption methods in both `KeyStore` and `CollectionsClient`. - The tests measure the time taken to decrypt a list of items/collections, asserting correctness while providing speedup metrics. - These additions enhance performance evaluation capabilities for decryption processes, ensuring efficient handling of large datasets.
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE Reviewed the addition of Code Review DetailsNo blocking findings. Minor consistency notes (not flagged as inline comments): the new |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
🔍 SDK Breaking Change DetectionSDK Version:
Breaking change detection uses the build of the SDK from this branch, including any incompatibities pre-existing on or merged into this branch. Check the workflow logs to confirm. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1253 +/- ##
==========================================
+ Coverage 85.09% 85.49% +0.39%
==========================================
Files 477 482 +5
Lines 65934 67393 +1459
==========================================
+ Hits 56109 57620 +1511
+ Misses 9825 9773 -52 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…rypto` and `bitwarden-vault` - Deleted the speed comparison tests that evaluated the performance of sequential versus bulk decryption methods in both `KeyStore` and `CollectionsClient`. - This cleanup reduces code clutter and focuses on maintaining essential test cases for decryption functionality.
4 participants
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-38906
📔 Objective
Utilize SDK for decryption and utilize decryptMany methods so only 1 SDK call is used