Skip to content

Conversation

@mark-youssef-bitwarden
Copy link
Collaborator

@mark-youssef-bitwarden mark-youssef-bitwarden commented Dec 19, 2024

🎟️ Tracking

Update astro and other packages to take care of security vulnerability.

  • The markdown parser API changed so I needed to update the parsers as well

📔 Objective

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

- Update markdown parsers to work with updated api
@mark-youssef-bitwarden mark-youssef-bitwarden requested a review from a team as a code owner December 19, 2024 23:02
@github-actions
Copy link

github-actions bot commented Dec 19, 2024

Logo
Checkmarx One – Scan Summary & Detailsc6c7318a-4bbd-4ae4-a569-e92443075341

No New Or Fixed Issues Found

@mark-youssef-bitwarden mark-youssef-bitwarden marked this pull request as draft December 19, 2024 23:47
@mark-youssef-bitwarden mark-youssef-bitwarden changed the title Update packages for security Update packages for security + PR previews Dec 19, 2024
@mark-youssef-bitwarden mark-youssef-bitwarden changed the title Update packages for security + PR previews Update packages for security Dec 20, 2024
@mark-youssef-bitwarden mark-youssef-bitwarden marked this pull request as ready for review December 20, 2024 00:05
@ljbw ljbw merged commit ddb5c90 into main Dec 20, 2024
9 checks passed
@ljbw ljbw deleted the update-packages branch December 20, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants