Skip to content

[PM-17659] [RC] Add learn more links for TOTP code syncing #1601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: release/2025.05-rc9
Choose a base branch
from

Conversation

matt-livefront
Copy link
Collaborator

@matt-livefront matt-livefront commented May 21, 2025

๐ŸŽŸ๏ธ Tracking

PM-17659

๐Ÿ“” Objective

  • Adds the "Learn more" link to the sync with Bitwarden action card on the verification codes list.
  • Adds the "Learn more" link and info text to the "Sync with Bitwarden" item in Settings.

๐Ÿ“ธ Screenshots

Screenshot 2025-05-21 at 2 20 39โ€ฏPM Screenshot 2025-05-21 at 2 20 43โ€ฏPM

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

Copy link

codecov bot commented May 21, 2025

Codecov Report

Attention: Patch coverage is 98.36066% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.80%. Comparing base (2881e2b) to head (b08673b).

Files with missing lines Patch % Lines
.../UI/Vault/ItemList/ItemList/ItemListCardView.swift 98.57% 1 Missing โš ๏ธ
...ared/UI/Vault/ItemList/ItemList/ItemListView.swift 75.00% 1 Missing โš ๏ธ
Additional details and impacted files
@@                   Coverage Diff                    @@
##           release/2025.05-rc9    #1601       +/-   ##
========================================================
- Coverage                89.74%   69.80%   -19.94%     
========================================================
  Files                      783      256      -527     
  Lines                    49365    11619    -37746     
========================================================
- Hits                     44303     8111    -36192     
+ Misses                    5062     3508     -1554     

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

๐Ÿš€ New features to boost your workflow:
  • โ„๏ธ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant