[BRE-769] Use Fastlane to keep github releases in sync with mobile deploy versions #1593
Conversation
michalchecinski
requested review from
a team and
Eeebru
and removed request for
a team
|
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1593 +/- ##
===========================================
- Coverage 89.74% 69.63% -20.11%
===========================================
Files 783 255 -528
Lines 49353 11542 -37811
===========================================
- Hits 44290 8037 -36253
+ Misses 5063 3505 -1558 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| latest_release=$(jq -r 'first' <<< $(curl --silent https://api.github.com/repos/bitwarden/ios/releases)) | ||
| is_latest_prerelease=$(jq -r '.prerelease' <<< $latest_release) | ||
| echo "is_latest_prerelease=$is_latest_prerelease" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
We create the releases as Drafts, not pre-releases; will those be picked up by that logic?
There was a problem hiding this comment.
@differsthecat It won't. I changed it to pick up the draft releases. Is it the same for android?
There was a problem hiding this comment.
Yes, that wil be the same for Android!
There was a problem hiding this comment.
Thanks! I'll change the worflows accordingly
…pre-release details and streamline release process
🎟️ Tracking
https://bitwarden.atlassian.net/browse/BRE-769
📔 Objective
Add a workflow to check for new iOS version submitted to the stores. If a new version exists, publish the GitHub release as the latest and non-pre-release.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes