Skip to content

[PM-18414] CI restructuring #6 - New build workflows, build-all, ci-bwpm and ci-bwa #1589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 57 commits into from
May 28, 2025

Conversation

vvolkgang
Copy link
Member

🎟️ Tracking

#1566

📔 Objective

New workflows inbound! :feelsgood: Summary of changes:

  • _build-any.yml as a Callable Workflow exclusively handles building, versioning and workflow triggers were shifted to callers.
  • ci-bwpm.yml | ci-bwa.yml files handle both manual builds and CI, by shifting GITHUB_RUN_NUMBER responsibility and manual builds out of _build-any.yml we're able to remove the need to call dispatch-and-download.yml for versions, speeding up builds.
  • Split building steps from app level configuration by introducing .env files per build variant - .env.bwpm_prod, .env.bwpm_beta, .env.bwa_prod.
  • Leverage fastlane for codebase preparation steps, supporting locally building all current and future build variants. Ruby will now be our go to language for less trivial scripts instead of bash.
  • Provides Authenticator all the build related goodies it was missing:
    1. Automatic versioning;
    2. Simulator builds;
    3. Exporting dSym files
    4. Crashlytics config support - filename will be updated in future PR;
    5. CI Build Info support - app will be updated to use this in a future PR;

Note

We'll merge these for manual build testing, On Push triggers will be introduced in a future PR where the existing CI files will be removed, so we don't create builds with conflicting version numbers

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@vvolkgang vvolkgang requested review from a team and matt-livefront as code owners May 15, 2025 22:03
Copy link
Contributor

github-actions bot commented May 15, 2025

Logo
Checkmarx One – Scan Summary & Details0501f809-f4e0-4b01-b790-f126d1446433

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented May 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.06%. Comparing base (4af08d0) to head (7ea8f5f).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1589      +/-   ##
==========================================
- Coverage   89.78%   86.06%   -3.73%     
==========================================
  Files         786      984     +198     
  Lines       49918    59820    +9902     
==========================================
+ Hits        44818    51483    +6665     
- Misses       5100     8337    +3237     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vvolkgang vvolkgang merged commit 9e3a1ca into main May 28, 2025
12 checks passed
@vvolkgang vvolkgang deleted the monorepo/new-build branch May 28, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants