Skip to content

Conversation

@KatherineInCode
Copy link
Contributor

📔 Objective

With the SUPPORTS_CXP flag off by default, some classes used by the CXP and its testing flows got moved without the CXP code being updated. This fixes that with imports and proper scoping.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsa46ea740-9184-4fde-84b3-7a5b77c33a1e

Great job, no security vulnerabilities found in this Pull Request

@codecov
Copy link

codecov bot commented Apr 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.95%. Comparing base (5ea1aad) to head (302635d).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1539      +/-   ##
==========================================
- Coverage   89.68%   85.95%   -3.74%     
==========================================
  Files         777      988     +211     
  Lines       48975    59242   +10267     
==========================================
+ Hits        43924    50921    +6997     
- Misses       5051     8321    +3270     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@KatherineInCode KatherineInCode marked this pull request as ready for review April 28, 2025 21:12
@KatherineInCode KatherineInCode requested review from a team and matt-livefront as code owners April 28, 2025 21:12
@KatherineInCode KatherineInCode merged commit 990fcc8 into main Apr 29, 2025
13 checks passed
@KatherineInCode KatherineInCode deleted the katherine/cxp-monorepo branch April 29, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants