Skip to content

distinguish published and accepted dates in front matter #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

distinguish published and accepted dates in front matter #626

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/architecture/adr/0025-ts-deprecate-enums.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
---
adr: "0025"
status: Proposed
status: Accepted
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ A main merge will clear this.

date: 2025-05-30
accepted: 2025-06-24
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ I'd like to attempt to get past dates and fill these out everywhere if we go forward with this.

tags: [clients, typescript]
---

Expand Down
6 changes: 6 additions & 0 deletions src/components/AdrTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,12 @@ export default function AdrTable({ frontMatter }): JSX.Element {
<th>Published:</th>
<td>{formatDate(frontMatter.date)}</td>
</tr>
{frontMatter.accepted && (
<tr>
<th>Accepted:</th>
<td>{formatDate(frontMatter.accepted)}</td>
</tr>
)}
</tbody>
</table>
);
Expand Down