accept enum-like proposal with edits mentioned during architecture review #624
+145
−130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying contributing-docs with
|
| Latest commit: |
041223d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://21d89f8a.contributing-docs.pages.dev |
| Branch Preview URL: | https://remove-strongly-typed-enum-l.contributing-docs.pages.dev |
|
Great job, no security vulnerabilities found in this Pull Request |
withinfocus
requested changes
Jun 24, 2025
withinfocus
previously approved these changes
Jun 24, 2025
This comment was marked as outdated.
This comment was marked as outdated.
audreyality
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
withinfocus
requested changes
Jun 24, 2025
withinfocus
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
N/A
📔 Objective
Update enum-like proposal to reflect architectural discussion:
Rendered: ADR-0025, avoid enums guidance, angular guidance
🦖 System Evolution
This PR also distinguishes published and accepted dates in the front matter. This wasn't mentioned in the architecture review. It's just useful to distinguish between when the ADR was proposed from when it comes into force.
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes