Skip to content

[BRE-831] migrate secrets AKV #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 9, 2025
Merged

[BRE-831] migrate secrets AKV #614

merged 7 commits into from
Jul 9, 2025

Conversation

pixman20
Copy link
Contributor

@pixman20 pixman20 commented Jun 12, 2025

🎟️ Tracking

BRE-831

📔 Objective

Updating to use Azure Key Vault Secrets in place of GitHub secrets.
All GitHub secrets have been migrated to the repository's respective Key Vault.
Azure Service Principals have been updated to use Managed Identities with OIDC.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

cloudflare-workers-and-pages bot commented Jun 12, 2025

Deploying contributing-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 661ab38
Status: ✅  Deploy successful!
Preview URL: https://f5f044a1.contributing-docs.pages.dev
Branch Preview URL: https://bre-831-migrate-secrets-akv.contributing-docs.pages.dev

View logs

Copy link

github-actions bot commented Jun 12, 2025

Logo
Checkmarx One – Scan Summary & Detailsa8e598a7-f1bd-4bab-9a4c-0037ec9df5be

Great job, no security vulnerabilities found in this Pull Request

@pixman20 pixman20 marked this pull request as ready for review June 26, 2025 22:35
@pixman20 pixman20 requested a review from a team as a code owner June 26, 2025 22:35
withinfocus
withinfocus previously approved these changes Jun 27, 2025
Copy link
Contributor

@withinfocus withinfocus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments on another one of these I came across, but this matches and is good to go regardless.

@pixman20 pixman20 merged commit ffbc2b8 into main Jul 9, 2025
10 checks passed
@pixman20 pixman20 deleted the BRE-831-migrate-secrets-akv branch July 9, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants