confirm passwords match between .env and secrets.json #597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying contributing-docs with
|
| Latest commit: |
800888f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1978c793.contributing-docs.pages.dev |
| Branch Preview URL: | https://add-dot-env-reminder.contributing-docs.pages.dev |
|
@jprusik - hope you don't mind I tagged you for this PR. |
|
Great job, no security vulnerabilities found in this Pull Request |
|
Gonna cause conflicts with #593. |
jprusik
previously approved these changes
May 23, 2025
I addressed the differences. The only conflict now should be that I moved "user secrets" above "updating the database". I can't include the link to the migration page since the page it refers to doesn't exist. |
jprusik
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
N/A
📔 Objective
@justindbaur pointed out that there's a
.envfile, so I've adjusted the instructions to include a step confirming the environment variables match.This PR also moves the application config above the database config so that a reader encounters
secrets.jsonbefore it's referenced by the database config section's tips.(rendered)
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes