Skip to content

Conversation

withinfocus
Copy link
Contributor

🎟️ Tracking

Internal change for BWWL v2.

📔 Objective

Adjusts the label workflow for some best practices but also to satisfy the new linter.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

cloudflare-workers-and-pages bot commented Jan 6, 2025

Deploying contributing-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7012d66
Status: ✅  Deploy successful!
Preview URL: https://56b13140.contributing-docs.pages.dev
Branch Preview URL: https://labeling.contributing-docs.pages.dev

View logs

@withinfocus withinfocus force-pushed the labeling branch 2 times, most recently from 29e40c3 to 35f129b Compare January 6, 2025 21:31
Copy link

github-actions bot commented Jan 6, 2025

Logo
Checkmarx One – Scan Summary & Details6795c2c3-8bb9-49d7-9494-046a8b63519e

No New Or Fixed Issues Found

@withinfocus withinfocus marked this pull request as ready for review January 6, 2025 21:44
@withinfocus withinfocus requested a review from a team as a code owner January 6, 2025 21:44
@withinfocus withinfocus merged commit ae8c8f4 into main Jan 6, 2025
8 checks passed
@withinfocus withinfocus deleted the labeling branch January 6, 2025 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants