[AC-1159] Fix disabledSso duplicate event log

[MarsCandyBars]

🎟️ Tracking

AC-1159

📔 Objective

Whether enabling or disabling SSO, event logs would read "SSO turned on". Adjusted the disabledSso object to be "SSO turned off"

📸 Screenshots

New behavior:

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[claude]

Claude finished @MarsCandyBars's task —— View job

---

Code Review Complete

• Read changed files and PR diff
• Check for related files that may need updates
• Evaluate PR description quality
• Provide comprehensive review feedback

---

Summary

The fix correctly addresses the duplicate "SSO turned on" message bug by changing disabledSso to show "SSO turned off". The change is minimal, correct, and localized translations already have the proper values.

Findings

Finding 1: PR title uses inconsistent style with past tense "fixed" instead of present tense

Finding 2: Other locale files already have correct translations but may be inconsistent with en

---

Finding 1: PR title uses inconsistent style with past tense "fixed" instead of present tense (💭)

apps/web/src/locales/en/messages.json:7126

The PR title uses past tense "AC-1159 fixed disabledSso duplicate event log" which is inconsistent with the commit message style typically used in this repository. Based on recent commits, titles should use present tense imperative mood.

Suggested rewrite:

[AC-1159] Fix disabledSso duplicate event log message

This is a minor stylistic point and doesn't affect functionality.

Finding 2: Other locale files already have correct translations but may be inconsistent with en (💭)

apps/web/src/locales/*/messages.json

I checked several major locale files (en_GB, fr, es, de) and found they already contain the correct "SSO turned off" translations:

• en_GB: "SSO turned off"
• fr: "SSO désactivé"
• es: "SSO desactivado"
• de: "SSO deaktiviert"

This suggests the bug was limited to the en locale. However, this raises a question: how did the other locales get the correct translation while en had the wrong one? Was this a previous localization sync that missed updating the source en locale?

This doesn't require any action in this PR, but it might be worth understanding how the translations diverged to prevent similar issues in the future.

---

Technical Correctness

The change is technically correct:

• The code in event.service.ts:375 references this.i18nService.t("disabledSso")
• The fix changes the English message from "SSO turned on" → "SSO turned off"
• The screenshot confirms the new behavior correctly displays "SSO turned off" for disable events
• Other locale files already have correct translations

PR Description Quality

The PR description is well-structured and complete:

• ✅ Clear objective explaining what and why
• ✅ Screenshot showing the new behavior
• ✅ Jira ticket linked
• ✅ Reminders checklist included

The only minor suggestion is the title style mentioned in Finding 1.

[github-actions]

Checkmarx One – Scan Summary & Details – 6110d2ee-abc3-423f-9aa6-2eac2f710caf

Great job! No new security vulnerabilities introduced in this pull request