Skip to content

Conversation

@maxkpower
Copy link
Contributor

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/PM-28536

๐Ÿ“” Objective

Adds a client-level setting to allow users to disable the phishing detection feature in the browser extension. The setting applies to all users logged into the extension.

  • New Service: PhishingDetectionSettingsService manages the global on/off state
  • UI: Added toggle in Account Security settings (visible to premium users only)

๐Ÿ“ธ Screenshots

image

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@github-actions
Copy link
Contributor

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 9a5291f0-3f31-4253-aaf5-f08e1bbd577a

Great job! No new security vulnerabilities introduced in this pull request

@bw-ghapp
Copy link
Contributor

bw-ghapp bot commented Nov 20, 2025

โš ๏ธ Changes in this PR impact the Autofill experience of the browser client โš ๏ธ

BIT has tested the core experience with these changes and all feature flags disabled.

Caution

Unfortunately, one or more of these tests failed. ๐Ÿ˜ž

Please resolve the failure before merging; reach out to @bitwarden/team-autofill-dev if you'd like help.

You can view the detailed results of the tests here.

@bw-ghapp
Copy link
Contributor

bw-ghapp bot commented Nov 20, 2025

โš ๏ธ Changes in this PR impact the Autofill experience of the browser client โš ๏ธ

BIT has tested the core experience with these changes and the feature flag configuration used by vault.bitwarden.com

Caution

Unfortunately, one or more of these tests failed. ๐Ÿ˜ž

Please resolve the failure before merging; reach out to @bitwarden/team-autofill-dev if you'd like help.

You can view the detailed results of the tests here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants