Skip to content

try to debug cause #17497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
+5 −0
Draft

try to debug cause #17497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
61f456c
try to debug cause
vleague2 Nov 19, 2025
a7f8043
remove debugging from has-scrolled-from
vleague2 Nov 20, 2025
3df51f7
try adjusting intersection observer threshold
vleague2 Nov 20, 2025
e804c65
debugging on scrollable content
vleague2 Nov 20, 2025
fb07a6c
Merge branch 'main' into uif/cl-923/dialog-border-chromatic
vleague2 Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions libs/components/src/dialog/dialog/dialog.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@
'tw-border-secondary-100': showFooterBorder,
}"
>
<p>{{ isScrollable }}</p>
<ng-content select="[bitDialogFooter]"></ng-content>
</footer>
</section>
4 changes: 4 additions & 0 deletions libs/components/src/utils/has-scrollable-content.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,12 @@ export const hasScrollableContent$ = (
observeOn(animationFrameScheduler),
map((entry: IntersectionObserverEntry | null) => {
if (!entry) {
document.body.prepend(
`[without entry: root ${root.scrollHeight} > client ${root.clientHeight}]`,
);
return root.scrollHeight > root.clientHeight;
}
document.body.prepend(`[with entry: ${!entry.isIntersecting}]`);
return !entry.isIntersecting;
}),
distinctUntilChanged(),
Expand Down
Loading