Skip to content

Conversation

@BTreston
Copy link
Contributor

@BTreston BTreston commented Nov 11, 2025

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/PM-26365

๐Ÿ“” Objective

Implements the one time dialog for the extension and hooks it up to local state.

๐Ÿ“ธ Screenshots

Screen.Recording.2025-11-20.at.2.55.01.PM.mov
Screen.Recording.2025-11-20.at.2.55.35.PM.mov

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2025

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 229c27e6-743c-47b9-ab9a-063f370db068

New Issues (1)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
MEDIUM CVE-2025-8129 Npm-koa-2.16.1
detailsRecommended version: 2.16.3
Description: A vulnerability, which was classified as problematic, was found in KoaJS Koa versions through 2.16.1 and versions 3.0.0-alpha0 through 3.0.0. Affec...
Attack Vector: NETWORK
Attack Complexity: LOW

ID: eLaNAkQldC3AAd6TidtskvhYwxpt9IKGn66nfX9YSIQ%3D
Vulnerable Package

@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

โŒ Patch coverage is 10.29412% with 122 lines in your changes missing coverage. Please review.
โœ… Project coverage is 40.66%. Comparing base (421edfb) to head (d9131bf).
โœ… All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...c/vault/popup/settings/admin-settings.component.ts 0.00% 48 Missing โš ๏ธ
...ards/automatic-user-confirmation-settings.guard.ts 0.00% 20 Missing โš ๏ธ
...lt/popup/components/vault-v2/vault-v2.component.ts 0.00% 14 Missing โš ๏ธ
...stom-nudges-services/auto-confirm-nudge.service.ts 35.71% 9 Missing โš ๏ธ
...ponents/auto-confirm-extension-dialog.component.ts 0.00% 8 Missing โš ๏ธ
.../src/tools/popup/settings/settings-v2.component.ts 0.00% 7 Missing โš ๏ธ
apps/browser/src/popup/services/services.module.ts 0.00% 3 Missing โš ๏ธ
...s/organization/organization.service.abstraction.ts 40.00% 3 Missing โš ๏ธ
apps/browser/src/popup/app-routing.module.ts 0.00% 2 Missing โš ๏ธ
libs/auto-confirm/src/index.ts 0.00% 2 Missing โš ๏ธ
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17339      +/-   ##
==========================================
- Coverage   40.69%   40.66%   -0.04%     
==========================================
  Files        3539     3546       +7     
  Lines      101355   101483     +128     
  Branches    15182    15190       +8     
==========================================
+ Hits        41250    41263      +13     
- Misses      58363    58479     +116     
+ Partials     1742     1741       -1     

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

๐Ÿš€ New features to boost your workflow:
  • ๐Ÿ“ฆ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BTreston
Copy link
Contributor Author

This is a stacked PR that depends on https://github.com/bitwarden/clients/pull/17258/files to be merged first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants