-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[deps]: Update GitHub Artifact Actions (major) #17305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Internal tracking:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #17305 +/- ##
==========================================
- Coverage 41.11% 41.11% -0.01%
==========================================
Files 3543 3543
Lines 101843 101849 +6
Branches 15265 15266 +1
==========================================
- Hits 41872 41871 -1
- Misses 58208 58214 +6
- Partials 1763 1764 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
02186d5 to
8f38ec2
Compare
djsmith85
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They mention, a breaking change by supporting Node 24. From the the way it is phrased I don't we are required to bump our workflows to use Node24 and can stay on Node 22. Currently I'd say this is save, but wanted to check with @bitwarden/dept-bre first. Any concerns?
|
Claude finished @renovate[bot]'s task —— View job PR Review: GitHub Artifact Actions UpdateSummaryThis renovate PR updates GitHub Actions for artifact handling from v4/v5 to v5/v6 respectively. The changes are technically correct and safe to merge. All version updates are applied consistently across 5 workflow files. Version Updates
Review FindingsClean PR - No issues found The PR successfully updates artifact actions across all build workflows. The changes are:
Breaking Change NoteThe v6.0.0 release mentions Node v24.x support as a "breaking change," but this is labeled conservatively. The actions remain compatible with existing Node.js versions (Node 22 is still fully supported). This is not a functional breaking change requiring workflow modifications. RecommendationApprove and merge. This is a routine dependency update with no functional impact. The PR is ready for merge based on successful CI runs and team approvals. |
|
Fixed Issues (53)Great job! The following issues were fixed in this Pull Request
|
4376788 to
0253e95
Compare
gitclonebrian
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated actions ran successfully in the PR checks, and other prod workflows are using upload-artifacts v5.0.0 successfully. 🚀
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
All other upload-artifacts actions were also bumped to 5.0.0 with #17305
…17538) * [deps]: Update actions/upload-artifact action to v4.6.2 * Bumping to 5.0.0. to keep all usages in sync All other upload-artifacts actions were also bumped to 5.0.0 with #17305 --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Daniel James Smith <[email protected]>





This PR contains the following updates:
v5.0.0->v6.0.0v4.6.0->v5.0.0v4.6.2->v5.0.0Release Notes
actions/download-artifact (actions/download-artifact)
v6.0.0Compare Source
What's Changed
BREAKING CHANGE: this update supports Node
v24.x. This is not a breaking change per-se but we're treating it as such.@actions/artifacttov4.0.0v6.0.0by @danwkennedy in #438New Contributors
Full Changelog: actions/download-artifact@v5...v6.0.0
actions/upload-artifact (actions/upload-artifact)
v5.0.0Compare Source
v4.6.2Compare Source
What's Changed
New Contributors
Full Changelog: actions/upload-artifact@v4...v4.6.2
v4.6.1Compare Source
What's Changed
Full Changelog: actions/upload-artifact@v4...v4.6.1
Configuration
📅 Schedule: Branch creation - "every 2nd week starting on the 2 week of the year before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.