Skip to content

Conversation

@BTreston
Copy link
Contributor

@BTreston BTreston commented Nov 6, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-26364

📔 Objective

This PR implements the new Extension UI for the Automatic User Confirmation (auto-confirm) feature.

  1. New Auto-Confirm Library (libs/auto-confirm/)
  • Created a standalone library
  • Migrate existing auto-confirm services, models, and abstractions into this library
  • Added README documenting the feature's purpose and security model
  1. Browser Extension Admin Settings Page
  • New component: admin-settings.component.ts (apps/browser/src/vault/popup/settings/)
  • Provides UI toggle for enabling/disabling auto-confirm in the browser extension
  • Shows warning dialog when enabling (with link to help documentation)
  • Implements spotlight/nudge notification for first-time setup
  1. Navigation & Routing
  • Added "Admin Settings" link to browser extension settings page
  • Integrated route in app-routing.module.ts with guard protection
  • Updated settings navigation template
  1. Auto-Confirm Nudge Service
  • Added auto-confirm-nudge.service.ts
  • Integrates with existing nudges system to show spotlight, berry, and badge nudges
  1. Guard Refactoring
  • Moved org-policy.guard.ts from admin-console to libs/angular/src/admin-console/guards/
  • Created new automatic-user-confirmation-settings.guard.ts for route protection
  1. Testing & Configuration
  • Enhanced test coverage for auto-confirm service
  • Updated Jest and ESLint configurations for new library

📸 Screenshots

DESIGN REVIEW

Screen.Recording.2025-11-20.at.2.30.58.PM.mov
Screen.Recording.2025-11-20.at.2.30.26.PM.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

Logo
Checkmarx One – Scan Summary & Detailsac4e3ce1-74b7-400a-add6-5743e549928d

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

❌ Patch coverage is 71.42857% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 41.28%. Comparing base (98401cc) to head (1971569).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...stom-nudges-services/auto-confirm-nudge.service.ts 35.71% 9 Missing ⚠️
.../src/tools/popup/settings/settings-v2.component.ts 0.00% 7 Missing ⚠️
apps/browser/src/popup/services/services.module.ts 0.00% 3 Missing ⚠️
...s/organization/organization.service.abstraction.ts 40.00% 3 Missing ⚠️
apps/browser/src/popup/app-routing.module.ts 0.00% 2 Missing ⚠️
...c/vault/popup/settings/admin-settings.component.ts 95.83% 2 Missing ⚠️
apps/web/src/app/oss-routing.module.ts 0.00% 1 Missing ⚠️
.../src/app/vault/individual-vault/vault.component.ts 0.00% 1 Missing ⚠️
libs/angular/src/admin-console/guards/index.ts 0.00% 1 Missing ⚠️
libs/auto-confirm/src/guards/index.ts 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17258      +/-   ##
==========================================
+ Coverage   41.25%   41.28%   +0.02%     
==========================================
  Files        3546     3551       +5     
  Lines      102062   102166     +104     
  Branches    15314    15320       +6     
==========================================
+ Hits        42108    42176      +68     
- Misses      58189    58226      +37     
+ Partials     1765     1764       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants