[CL-806] Focus main content after side nav navigation occurs #17112
+71
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17112 +/- ##
==========================================
- Coverage 41.25% 41.24% -0.01%
==========================================
Files 3546 3547 +1
Lines 102024 102044 +20
Branches 15302 15306 +4
==========================================
+ Hits 42087 42089 +2
- Misses 58173 58191 +18
Partials 1764 1764 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
willmartian
requested changes
Nov 18, 2025
apps/web/src/app/app.component.ts
Outdated
Comment on lines
132
to
142
| return { | ||
| navEvent, | ||
| currentNavInfo: info, | ||
| }; | ||
| }), | ||
| filter((navEventAndData) => { | ||
| const info = navEventAndData.currentNavInfo; | ||
|
|
||
| return info === undefined ? true : info?.focusMainAfterNav !== false; | ||
| }), | ||
| ) |
Contributor
There was a problem hiding this comment.
Why return navEvent and info if we are only using info?
apps/web/src/app/app.component.ts
Outdated
Comment on lines
117
to
126
| if (this.isFirstPageLoad) { | ||
| this.isFirstPageLoad = false; | ||
| return false; | ||
| } | ||
|
|
||
| return true; | ||
| } | ||
|
|
||
| return false; | ||
| }), |
Contributor
There was a problem hiding this comment.
We can call skip(1) from rxjs instead of using the class property isFirstPageLoad
Contributor
There was a problem hiding this comment.
We should move this logic into a service in libs/components/a11y
Contributor
|
Thoughts on feature flagging this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
📔 Objective
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes