Skip to content

PM-22836 Import popout crashes unexpectedly #16928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
+130 −31

avoid race condition in SendFilePopoutDialogContainerComponent

da43ca3
Select commit
Loading
Failed to load commit list.
Open

PM-22836 Import popout crashes unexpectedly #16928

avoid race condition in SendFilePopoutDialogContainerComponent
da43ca3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 20, 2025 in 0s

41.23% (-0.01%) compared to 9e6d0cc

View this Pull Request on Codecov

41.23% (-0.01%) compared to 9e6d0cc

Details

Codecov Report

❌ Patch coverage is 0% with 42 lines in your changes missing coverage. Please review.
✅ Project coverage is 41.23%. Comparing base (9e6d0cc) to head (da43ca3).
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...log/send-file-popout-dialog-container.component.ts 0.00% 13 Missing ⚠️
...t/import-file-popout-dialog-container.component.ts 0.00% 12 Missing ⚠️
...ings/import/import-file-popout-dialog.component.ts 0.00% 12 Missing ⚠️
...popout-dialog/send-file-popout-dialog.component.ts 0.00% 4 Missing ⚠️
...pup/settings/import/import-browser-v2.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #16928      +/-   ##
==========================================
- Coverage   41.23%   41.23%   -0.01%     
==========================================
  Files        3543     3548       +5     
  Lines      101963   102053      +90     
  Branches    15295    15304       +9     
==========================================
+ Hits        42048    42082      +34     
- Misses      58152    58206      +54     
- Partials     1763     1765       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov