Skip to content

Conversation

@djsmith85
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-26030

📔 Objective

When importing using the new chromium importer and the target browser does not have any logins to import, it would just show a generic error. This refines it to re-use the message we show on other importers

📸 Screenshots

image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@djsmith85 djsmith85 requested a review from a team as a code owner October 3, 2025 13:32
@djsmith85 djsmith85 added the needs-qa Marks a PR as requiring QA approval label Oct 3, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 3, 2025

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2025

Logo
Checkmarx One – Scan Summary & Details478da5b7-26e7-45e7-b993-125c2eae9b21

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Oct 3, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 38.80%. Comparing base (f7a3ad8) to head (b27155e).
⚠️ Report is 13 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...r/src/components/chrome/import-chrome.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16723      +/-   ##
==========================================
- Coverage   38.81%   38.80%   -0.01%     
==========================================
  Files        3406     3406              
  Lines       96640    96640              
  Branches    14510    14510              
==========================================
- Hits        37509    37502       -7     
- Misses      57493    57500       +7     
  Partials     1638     1638              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@djsmith85 djsmith85 removed the needs-qa Marks a PR as requiring QA approval label Oct 3, 2025
@djsmith85 djsmith85 merged commit 9684112 into main Oct 3, 2025
128 of 131 checks passed
@djsmith85 djsmith85 deleted the tools/pm-26030/replace-generic-message-when-no-logins-where-found branch October 3, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants