-
Notifications
You must be signed in to change notification settings - Fork 1.5k
PM-2035: PRF Unlock (web + extension) #16662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
abergs
wants to merge
51
commits into
main
Choose a base branch
from
anders/unlock-prf-3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 48 commits
Commits
Show all changes
51 commits
Select commit
Hold shift + click to select a range
32af249
PM-13632: Enable sign in with passkeys in the browser extension
abergs 4c77de2
Refactor component + Icon fix
abergs 935efe0
Add tracking links
abergs 9042503
Update app.module.ts
abergs 9860ae1
Remove default Icons on load
abergs 85281b7
Remove login.module.ts
abergs 7df9721
Add env changer to the passkey component
abergs 308ee89
Remove leftover dependencies
abergs 37d3d2e
PRF Unlock
abergs 821a713
Workaround prf type missing
abergs 25586cf
Fix any type
abergs e7bf0a0
Undo accidental cleanup to keep PR focused
abergs 0a8045d
Undo accidental cleanup to keep PR focused
abergs b50f845
Cleaned up public interface
abergs 62c4796
Use UserId type
abergs 0437660
Typed UserId and improved isPrfUnlockAvailable
abergs 1c2f7da
Rename key and use zero challenge array
abergs c612616
logservice
abergs c121ef3
Cleanup rpId handling
abergs 5259edc
Refactor to separate component + icon
abergs 8092bfc
Moved the prf unlock service impl.
abergs dd17532
Fix broken test
abergs 07fc6b1
fix tests
abergs 8232f21
Merge branch 'main' into anders/unlock-prf-3
abergs df2dd00
Use isChromium
abergs a53b5a8
Update services.module.ts
abergs f32586c
missing , in locales
abergs d055532
Update desktop-lock-component.service.ts
abergs ec48f8c
Fix more desktoptests
abergs 5cd63a4
Expect a single UnlockOption from IdTokenResponse, but multiple from โฆ
abergs 9bf897d
Missing s
abergs 88872fb
remove catches
abergs 6db2221
Use new control flow in unlock-via-prf.component.ts
abergs 3391639
Changed throw behaviour of unlockVaultWithPrf
abergs 18546d4
remove timeout comment
abergs 8772f78
refactired webauthm-prf-unlock.service internally
abergs d8f7afb
WebAuthnPrfUnlockServiceAbstraction -> WebAuthnPrfUnlockService
abergs 117709f
Fixed any and bad import
abergs df4caf6
Merge branch 'main' into anders/unlock-prf-3
abergs d18777b
Fix errors after merge
abergs b1288d5
Added missing PinServiceAbstraction
abergs c293b14
Fixed format
abergs c45c9f9
Removed @Inject()
abergs cad51ae
Fix broken tests after Inject removal
abergs 7684a5e
Merge branch 'main' into anders/unlock-prf-3
abergs ef875ad
Return userkey instead of setting it
abergs b01dbbf
Used input/output signals
abergs c53cfe3
removed duplicate MessageSender registration
abergs 26a628a
nit: Made import relative
abergs caafd3d
Disable onPush requirement because it would need refactoring the compโฆ
abergs 377664c
Added feature flag (#17494)
abergs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.