-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[PM-23995] Updated change kdf component for Forced update KDF settings #16516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16516 +/- ##
==========================================
+ Coverage 39.25% 39.37% +0.11%
==========================================
Files 3467 3468 +1
Lines 98629 98658 +29
Branches 14799 14802 +3
==========================================
+ Hits 38719 38848 +129
+ Misses 58231 58129 -102
- Partials 1679 1681 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Patrick-Pimentel-Bitwarden
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Auth changes are good
# Conflicts: # apps/web/src/app/key-management/change-kdf/change-kdf.component.html # apps/web/src/app/key-management/change-kdf/change-kdf.module.ts # apps/web/src/locales/en/messages.json
|
Not seeing any auth changes, removing myself from the review, please add me back if that's not the case. |
# Conflicts: # apps/web/src/app/key-management/change-kdf/change-kdf-confirmation.component.ts
Signed-off-by: Maciej Zieniuk <[email protected]>
Thomas-Avery
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, a few minor things to check out from my side.
apps/web/src/app/key-management/change-kdf/change-kdf-confirmation.component.ts
Outdated
Show resolved
Hide resolved
apps/web/src/app/key-management/change-kdf/change-kdf-confirmation.component.spec.ts
Outdated
Show resolved
Hide resolved
apps/web/src/app/key-management/change-kdf/change-kdf-confirmation.component.spec.ts
Outdated
Show resolved
Hide resolved
apps/web/src/app/key-management/change-kdf/change-kdf-confirmation.component.spec.ts
Outdated
Show resolved
Hide resolved
apps/web/src/app/key-management/change-kdf/change-kdf.component.html
Outdated
Show resolved
Hide resolved
apps/web/src/app/key-management/change-kdf/change-kdf.component.ts
Outdated
Show resolved
Hide resolved
apps/web/src/app/key-management/change-kdf/change-kdf.component.spec.ts
Outdated
Show resolved
Hide resolved
apps/web/src/app/key-management/change-kdf/change-kdf.component.spec.ts
Outdated
Show resolved
Hide resolved
# Conflicts: # apps/web/src/locales/en/messages.json
Thomas-Avery
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
# Conflicts: # apps/web/src/locales/en/messages.json
# Conflicts: # apps/web/src/locales/en/messages.json # libs/common/src/enums/feature-flag.enum.ts
|




🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-23995
📔 Objective
Updated change kdf component for Forced update KDF settings work.
See Jira for figma designs.
Visual changes:
pm-23995-no-logout-on-kdf-changefeature flag is enabled:Functional changes:
pm-23995-no-logout-on-kdf-changefeature flag is enabled, does not log out the user.Dependent on #16515 , which moves the change KDF component into KM ownership
📸 Screenshots
Feature flag on:
Video:
2025-10-04.12-10-41.mp4
PBKDF2:
Argon2Id:
Confirmation dialog:
About encryption algorithms popover:
Error cases:
Kdf iterations field missing:
Kdf iterations below minimum:
Feature flag off:
Confirmation dialog:
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes