-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[deps] Platform: Update electron to v38 #16423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16423 +/- ##
=======================================
Coverage 38.76% 38.77%
=======================================
Files 3408 3408
Lines 96742 96742
Branches 14519 14519
=======================================
+ Hits 37503 37510 +7
+ Misses 57602 57595 -7
Partials 1637 1637 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Internal tracking:
|
11aabf9 to
a18d9f4
Compare
a18d9f4 to
ff7acbe
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
|
Fixed Issues (17)Great job! The following issues were fixed in this Pull Request
|
|







Coming soon: The Renovate bot (GitHub App) will be renamed to Mend. PRs from Renovate will soon appear from 'Mend'. Learn more here.
This PR contains the following updates:
36.8.1->38.1.0Release Notes
electron/electron (electron)
v38.1.0: electron v38.1.0Compare Source
Release Notes for v38.1.0
Other Changes
v38.0.0: electron v38.0.0Compare Source
Release Notes for v38.0.0
Stack Upgrades
140.0.7339.4122.18.014.0Breaking Changes
Features
Additions
before-mouse-eventto allow intercepting and preventing mouse events in WebContents. #47280 (Also in 36, 37)fileBackedandpurgeablefields toprocess.getSystemMemoryInfo()for macOS. #48146 (Also in 37)innerWidthandinnerHeightoptions for window.open. #46749 (Also in 35, 36, 37)tray.{get|set}AutosaveNameto enable macOS tray icons to maintain position across launches. #48077 (Also in 36, 37)webFrameMain.fromFrameToken(processId, frameToken)to get aWebFrameMaininstance from its frame token. #47942app.getRecentDocuments()on Windows and macOS. #47924 (Also in 36, 37)--no-experimental-global-navigatorflag. #47370 (Also in 35, 36, 37)HIDDevice.collections. #47391 (Also in 36, 37)screen.dipToScreenPoint(point)andscreen.screenToDipPoint(point)on Linux X11. #46211 (Also in 35, 36, 37)paletteandheaderon macOS. #45538 (Also in 37)--experimental-network-inspection. #46690 (Also in 35, 36, 37){get|set}AccentColor. #47939 (Also in 36, 37)Improvements
win.isContentProtected()to allow developers to check window protection status. #47242 (Also in 36, 37)DIR_ASSETSinstead ofDIR_MODULE/DIR_EXEto locate assets and resources, and added "assets" as a key that can be queried viaapp.getPath. #47950 (Also in 37)Fixes
dialog.showMessageDialogshowed a window incorrectly centered to monitor instead of parent window when passed. #48215chrome://accessibilitypage. #47497Also in earlier versions...
addChildView()crashes when adding a closed WebContentsView. #47099 (Also in 35, 36, 37)appextensions filters didn't allow for selecting app bundles in macOS file dialogs. #47841 (Also in 36, 37)Refererheader was not being set correctly when usingwebContents.downloadURL(). #47867 (Also in 36, 37)webContents.loadURL()from a failedwebContents.loadURL()call's catch handler. #48043 (Also in 36, 37)-electron-corner-smoothingCSS rule to a stylesheet with no associated document. #47785 (Also in 37)desktopCapturer.getSourceswith an empty thumbnail size. #47652 (Also in 36, 37)webContentsfunctions afterwindow.close(). #47952 (Also in 36, 37)session.clearDatain some circumstances. #47361 (Also in 35, 36, 37)electronfor the first time from an ESM module loaded by a CJS module in a packaged app. #46810 (Also in 35, 36, 37)setContentProtectiondidn't work as expected. #47886 (Also in 36, 37)app.accessibilitySupportEnableddidn't work as expected. #48060 (Also in 37)net.isOnline()always returnedtruein utilityProcesses. #48151 (Also in 36, 37)require('node:sqlite')didn't work. #47757 (Also in 36, 37)shell.openPathwas not non-blocking as expected. #48089 (Also in 36, 37)webContents.printdid not work as expected whenmediaSizewas not passed. #46937 (Also in 36, 37)accentColorwould result in a white accent color. #47684 (Also in 37)Fetch.continueResponsevia debugger withWebContentsViewcould cause a crash. #47434 (Also in 35, 36, 37)roundedCornersset tofalse. #47681 (Also in 36, 37)contextmenuevent was emitted. #48224 (Also in 36, 37)electron/utilityin an ESM file threw an error at runtime. #48019 (Also in 36, 37)electron/utilitythrew aERR_MODULE_NOT_FOUNDerror at runtime. #47989 (Also in 36, 37)webContents.print({ silent: true })would fail. #47378 (Also in 36, 37)window.openwould never be offscreen. #48026 (Also in 37)autoUpdateron macOS when zip extraction failed. #47271 (Also in 34, 35, 36, 37)treatPackageAsDirectoryis enabled on macOS. #47077 (Also in 35, 36, 37)app.getLoginItemSettingson macOS. #48094 (Also in 36, 37)webContents.print()where the callback would not be called. #47377 (Also in 35, 36, 37)win.setContentProtected()on Windows. #47020 (Also in 35, 36, 37)Documentation
Notices
End of Support for 35.x.y
Electron 35.x.y has reached end-of-support as per the project's support policy. Developers and applications are encouraged to upgrade to a newer version of Electron.
v37.5.1: electron v37.5.1Compare Source
Release Notes for v37.5.1
Other Changes
v37.5.0: electron v37.5.0Compare Source
Release Notes for v37.5.0
Features
fileBackedandpurgeablefields toprocess.getSystemMemoryInfo()for macOS. #48143 (Also in 38)Fixes
dialog.showMessageDialogshowed a window incorrectly centered to monitor instead of parent window when passed. #48213 (Also in 36, 38)contextmenuevent was emitted. #48226 (Also in 36, 38)Other Changes
v37.4.0: electron v37.4.0Compare Source
Release Notes for v37.4.0
Features
tray.{get|set}AutosaveNameto enable macOS tray icons to maintain position across launches. #48076 (Also in 36, 38)Fixes
net.isOnline()always returnedtruein utilityProcesses. #48152 (Also in 36, 38)Other Changes
v37.3.1: electron v37.3.1Compare Source
Release Notes for v37.3.1
Fixes
shell.openPathwas not non-blocking as expected. #48088 (Also in 36, 38)window.openwould never be offscreen. #48070 (Also in 38)app.getLoginItemSettingson macOS. #48096 (Also in 36)Other Changes
v37.3.0: electron v37.3.0Compare Source
Release Notes for v37.3.0
Features
app.getRecentDocuments()on Windows and macOS. #47923 (Also in 36, 38){get|set}AccentColor. #48017 (Also in 36, 38)DIR_ASSETSinstead ofDIR_MODULE/DIR_EXEto locate assets and resources, and added "assets" as a key that can be queried viaapp.getPath. #47951 (Also in 38)Fixes
webContents.loadURL()from a failedwebContents.loadURL()call's catch handler. #48045 (Also in 36, 38)app.accessibilitySupportEnableddidn't work as expected. #48061 (Also in 38)electron/utilityin an ESM file threw an error at runtime. #48021 (Also in 36, 38)electron/utilitythrew aERR_MODULE_NOT_FOUNDerror at runtime. #47988 (Also in 36, 38)Other Changes
v37.2.6: electron v37.2.6Compare Source
Release Notes for v37.2.6
Fixes
Refererheader was not being set correctly when usingwebContents.downloadURL(). #47865 (Also in 36, 38)webContentsfunctions afterwindow.close(). #47954 (Also in 36, 38)setContentProtectiondidn't work as expected. #47887 (Also in 36, 38)accentColorwould result in a white accent color. #47800 (Also in 38)Other Changes
v37.2.5: electron v37.2.5Compare Source
Release Notes for v37.2.5
Other Changes
v37.2.4: electron v37.2.4Compare Source
Release Notes for v37.2.4
Fixes
appextensions filters didn't allow for selecting app bundles in macOS file dialogs. #47839 (Also in 36, 38)Other Changes
v37.2.3: electron v37.2.3Compare Source
Release Notes for v37.2.3
Fixes
-electron-corner-smoothingCSS rule to a stylesheet with no associated document. #47792require('node:sqlite')didn't work. #47756 (Also in 36, 38)v37.2.2: electron v37.2.2Compare Source
Release Notes for v37.2.2
Other Changes
v37.2.1: electron v37.2.1Compare Source
Release Notes for v37.2.1
Fixes
desktopCapturer.getSourceswith an empty thumbnail size. #47653 (Also in 36, 38)roundedCornersset tofalse. #47682 (Also in 36, 38)v37.2.0: electron v37.2.0Compare Source
Release Notes for v37.2.0
Other Changes
v37.1.0: electron v37.1.0Compare Source
Release Notes for v37.1.0
Features
Fixes
v37.0.0: electron v37.0.0Compare Source
Release Notes for v37.0.0
Stack Upgrades
138.0.7204.3522.16.013.8Breaking Changes
ProtocolResponse.session's property tonull. #46264Features
Additions
BrowserWindow.isSnapped()to indicate whether a given window has been arranged via Snap. #46079 (Also in 36)before-mouse-eventto allow intercepting and preventing mouse events in WebContents. #47364 (Also in 36)ffmpeg.dllto delay load configuration. #46151 (Also in 34, 35, 36)innerWidthandinnerHeightoptions for window.open. #47039 (Also in 35, 36)nativeTheme.shouldUseDarkColorsForSystemIntegratedUIto distinguish system and app theme. #46438 (Also in 35, 36)scriptURLproperty toServiceWorkerMain. #45863frameoption inmenu.popup. #45138 (Also in 36)HIDDevice.collections. #47483 (Also in 36)--no-experimental-global-navigatorflag. #47418 (Also in 35, 36)screen.dipToScreenPoint(point)andscreen.screenToDipPoint(point)on Linux X11. #46895 (Also in 35, 36)system-context-menuon Linux. #45848 (Also in 35, 36)paletteandheaderon macOS. #47245--experimental-network-inspection. #47031 (Also in 35, 36)win.isContentProtected()to allow developers to check window protection status. #47310 (Also in 36)Improvements
Removed/Deprecated
NativeImage.getBitmap()and fixed incorrect documentation. #46696 (Also in 36)Fixes
webContents.print({ silent: true })would fail. #47397Also in earlier versions...
addChildView()crashes when adding a closed WebContentsView. #47338 (Also in 35, 36)electron.shell.openExternalandelectron.shell.openPathto honor user-defined system defaults on Linux. #45310 (Also in 33, 34, 35, 36)getNativeWindowHandle()crash that affected 36 betas on macOS. #46733 (Also in 36)webContents.print(). #46087 (Also in 35, 36)shell.readShortcutLink. #46294 (Also in 35, 36)navigator.bluetooth.requestDeviceand theselect-bluetooth-deviceevent. #46745 (Also in 34, 35, 36)parentPort. #46437 (Also in 34, 35, 36)utilityProcess.postMessagewhen calling with an invalid transferable. #46639 (Also in [35](ht