PM-22143 Refactor TS enums to be const objects (Send specific enums)

apps/browser/src/tools/popup/send-v2/add-edit/send-add-edit.component.ts

@@ -41,7 +41,7 @@ import { SendFilePopoutDialogContainerComponent } from "../send-file-popout-dial
 class QueryParams {
   constructor(params: Params) {
     this.sendId = params.sendId;
-    this.type = parseInt(params.type, 10);
+    this.type = parseInt(params.type, 10) as SendType;
   }
 
   /**

apps/browser/src/tools/popup/send-v2/send-v2.component.spec.ts

@@ -37,7 +37,7 @@ import { PopupHeaderComponent } from "../../../platform/popup/layout/popup-heade
 import { PopupPageComponent } from "../../../platform/popup/layout/popup-page.component";
 import { PopupRouterCacheService } from "../../../platform/popup/view-cache/popup-router-cache.service";
 
-import { SendV2Component, SendState } from "./send-v2.component";
+import { SendV2Component } from "./send-v2.component";
 
 describe("SendV2Component", () => {
   let component: SendV2Component;
@@ -142,12 +142,12 @@ describe("SendV2Component", () => {
   it("should set listState to Empty when emptyList$ emits true", () => {
     sendItemsServiceEmptyList$.next(true);
     fixture.detectChanges();
-    expect(component["listState"]).toBe(SendState.Empty);
+    expect(component["listState"]).toBe(component["sendState"].Empty);
   });
 
   it("should set listState to NoResults when noFilteredResults$ emits true", () => {
     sendItemsServiceNoFilteredResults$.next(true);
     fixture.detectChanges();
-    expect(component["listState"]).toBe(SendState.NoResults);
+    expect(component["listState"]).toBe(component["sendState"].NoResults);
   });
 });

apps/browser/src/tools/popup/send-v2/send-v2.component.ts

@@ -30,12 +30,12 @@ import { PopOutComponent } from "../../../platform/popup/components/pop-out.comp
 import { PopupHeaderComponent } from "../../../platform/popup/layout/popup-header.component";
 import { PopupPageComponent } from "../../../platform/popup/layout/popup-page.component";
 
-// FIXME: update to use a const object instead of a typescript enum
-// eslint-disable-next-line @bitwarden/platform/no-enums
-export enum SendState {
-  Empty,
-  NoResults,
-}
+export const SendState = Object.freeze({
+  Empty: "Empty",
+  NoResults: "NoResults",
+} as const);
+
+export type SendState = (typeof SendState)[keyof typeof SendState];
 
 @Component({
   templateUrl: "send-v2.component.html",
@@ -83,7 +83,7 @@ export class SendV2Component implements OnDestroy {
       .pipe(takeUntilDestroyed())
       .subscribe(([emptyList, noFilteredResults, currentFilter]) => {
         if (currentFilter?.sendType !== null) {
-          this.title = `${this.sendType[currentFilter.sendType].toLowerCase()}Sends`;
+          this.title = `${currentFilter.sendType === SendType.File ? "file" : "text"}Sends`;
         } else {
           this.title = "allSends";
         }

apps/cli/src/tools/send/send.program.ts

@@ -307,7 +307,7 @@ export class SendProgram extends BaseProgram {
     let sendFile = null;
     let sendText = null;
     let name = Utils.newGuid();
-    let type = SendType.Text;
+    let type: SendType = SendType.Text;
     if (options.file != null) {
       data = path.resolve(data);
       if (!fs.existsSync(data)) {
@@ -316,7 +316,7 @@ export class SendProgram extends BaseProgram {
 
       sendFile = SendFileResponse.template(data);
       name = path.basename(data);
-      type = SendType.File;
+      type = SendType.File as SendType;
     } else {
       sendText = SendTextResponse.template(data, options.hidden);
     }

apps/desktop/desktop_native/napi/index.d.ts

@@ -228,8 +228,8 @@ export declare namespace chromium_importer {
     login?: Login
     failure?: LoginImportFailure
   }
-  export function getInstalledBrowsers(): Promise<Array<string>>
-  export function getAvailableProfiles(browser: string): Promise<Array<ProfileInfo>>
+  export function getInstalledBrowsers(): Array<string>
+  export function getAvailableProfiles(browser: string): Array<ProfileInfo>
   export function importLogins(browser: string, profileId: string): Promise<Array<LoginImportResult>>
 }
 export declare namespace autotype {

apps/desktop/src/app/tools/send/send.component.ts

@@ -25,13 +25,13 @@ import { SearchBarService } from "../../layout/search/search-bar.service";
 
 import { AddEditComponent } from "./add-edit.component";
 
-// FIXME: update to use a const object instead of a typescript enum
-// eslint-disable-next-line @bitwarden/platform/no-enums
-enum Action {
-  None = "",
-  Add = "add",
-  Edit = "edit",
-}
+export const Action = Object.freeze({
+  None: "",
+  Add: "add",
+  Edit: "edit",
+} as const);
+
+export type Action = (typeof Action)[keyof typeof Action];
 
 const BroadcasterSubscriptionId = "SendComponent";
 

libs/angular/src/tools/send/add-edit.component.ts

@@ -35,19 +35,18 @@ import { SendApiService } from "@bitwarden/common/tools/send/services/send-api.s
 import { SendService } from "@bitwarden/common/tools/send/services/send.service.abstraction";
 import { DialogService, ToastService } from "@bitwarden/components";
 
-// Value = hours
-// FIXME: update to use a const object instead of a typescript enum
-// eslint-disable-next-line @bitwarden/platform/no-enums
-enum DatePreset {
-  OneHour = 1,
-  OneDay = 24,
-  TwoDays = 48,
-  ThreeDays = 72,
-  SevenDays = 168,
-  ThirtyDays = 720,
-  Custom = 0,
-  Never = null,
-}
+export const DatePreset = Object.freeze({
+  OneHour: 1,
+  OneDay: 24,
+  TwoDays: 48,
+  ThreeDays: 72,
+  SevenDays: 168,
+  ThirtyDays: 720,
+  Custom: 0,
+  Never: -1,
+} as const);
+
+export type DatePreset = (typeof DatePreset)[keyof typeof DatePreset];
 
 interface DatePresetSelectOption {
   name: string;
@@ -114,7 +113,7 @@ export class AddEditComponent implements OnInit, OnDestroy {
     type: [],
     defaultExpirationDateTime: [],
     defaultDeletionDateTime: ["", Validators.required],
-    selectedDeletionDatePreset: [DatePreset.SevenDays, Validators.required],
+    selectedDeletionDatePreset: [DatePreset.SevenDays as DatePreset, Validators.required],
     selectedExpirationDatePreset: [],
   });
 

libs/common/src/tools/send/enums/send-type.ts

@@ -1,6 +1,6 @@
-// FIXME: update to use a const object instead of a typescript enum
-// eslint-disable-next-line @bitwarden/platform/no-enums
-export enum SendType {
-  Text = 0,
-  File = 1,
-}
+export const SendType = Object.freeze({
+  Text: 0,
+  File: 1,
+} as const);
+
+export type SendType = (typeof SendType)[keyof typeof SendType];

libs/tools/export/vault-export/vault-export-ui/src/enums/encrypted-export-type.enum.ts

@@ -1,6 +1,6 @@
-// FIXME: update to use a const object instead of a typescript enum
-// eslint-disable-next-line @bitwarden/platform/no-enums
-export enum EncryptedExportType {
-  AccountEncrypted = 0,
-  FileEncrypted = 1,
-}
+export const EncryptedExportType = Object.freeze({
+  AccountEncrypted: 0,
+  FileEncrypted: 1,
+} as const);
+
+export type EncryptedExportType = (typeof EncryptedExportType)[keyof typeof EncryptedExportType];

libs/tools/send/send-ui/src/add-edit/send-add-edit-dialog.component.ts

@@ -35,19 +35,12 @@ export interface SendItemDialogParams {
   disableForm?: boolean;
 }
 
-// FIXME: update to use a const object instead of a typescript enum
-// eslint-disable-next-line @bitwarden/platform/no-enums
-export enum SendItemDialogResult {
-  /**
-   * A Send was saved (created or updated).
-   */
-  Saved = "saved",
+export const SendItemDialogResult = Object.freeze({
+  Saved: "saved",
+  Deleted: "deleted",
+} as const);
 
-  /**
-   * A Send was deleted.
-   */
-  Deleted = "deleted",
-}
+export type SendItemDialogResult = (typeof SendItemDialogResult)[keyof typeof SendItemDialogResult];
 
 /**
  * Component for adding or editing a send item.

libs/tools/send/send-ui/src/send-form/components/send-details/send-details.component.ts

@@ -29,18 +29,17 @@ import { SendOptionsComponent } from "../options/send-options.component";
 import { SendFileDetailsComponent } from "./send-file-details.component";
 import { SendTextDetailsComponent } from "./send-text-details.component";
 
-// Value = hours
-// FIXME: update to use a const object instead of a typescript enum
-// eslint-disable-next-line @bitwarden/platform/no-enums
-export enum DatePreset {
-  OneHour = 1,
-  OneDay = 24,
-  TwoDays = 48,
-  ThreeDays = 72,
-  SevenDays = 168,
-  FourteenDays = 336,
-  ThirtyDays = 720,
-}
+export const DatePreset = Object.freeze({
+  OneHour: 1,
+  OneDay: 24,
+  TwoDays: 48,
+  ThreeDays: 72,
+  SevenDays: 168,
+  FourteenDays: 336,
+  ThirtyDays: 720,
+} as const);
+
+export type DatePreset = (typeof DatePreset)[keyof typeof DatePreset];
 
 export interface DatePresetSelectOption {
   name: string;