Skip to content

Conversation

@nick-livefront
Copy link
Collaborator

@nick-livefront nick-livefront commented Aug 29, 2025

🎟️ Tracking

N/A

📔 Objective

#14962 introduced some typing changes, on main these are failing because of:

  • string | undefined being passed to uuidAsString
  • Missing load_flags within a test file for the SDK client

📸 Screenshots

N/A

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@nick-livefront nick-livefront requested a review from a team as a code owner August 29, 2025 18:42
@nick-livefront nick-livefront changed the title Fix SDK typings for uuidAsString Fix SDK typings Aug 29, 2025
@nick-livefront nick-livefront requested a review from a team as a code owner August 29, 2025 18:51
@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2025

Logo
Checkmarx One – Scan Summary & Details4811c3fc-aba4-4071-87f0-9679647bffa1

Great job! No new security vulnerabilities introduced in this pull request

@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Aug 29, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.25%. Comparing base (d57d653) to head (c0786ca).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...bs/vault/src/services/copy-cipher-field.service.ts 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #16223   +/-   ##
=======================================
  Coverage   37.24%   37.25%           
=======================================
  Files        3347     3347           
  Lines       94995    95011   +16     
  Branches    14355    14359    +4     
=======================================
+ Hits        35381    35392   +11     
- Misses      58050    58053    +3     
- Partials     1564     1566    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nick-livefront nick-livefront merged commit de928e9 into main Aug 29, 2025
99 checks passed
@nick-livefront nick-livefront deleted the fix-sdk-typings branch August 29, 2025 19:27
vlad-trofimov pushed a commit to vlad-trofimov/clients that referenced this pull request Sep 30, 2025
* fix SDK typings for `uuidAsString`

* add `load_flags` to mock SDK instance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants