-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[deps] SM: Update jest (major) #15500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Internal tracking:
|
7d2139b to
06f487e
Compare
|
3b970f8 to
258954c
Compare
258954c to
7b3ee1d
Compare
7b3ee1d to
7136edc
Compare
b92eec3 to
2951a17
Compare
2951a17 to
6e59f32
Compare
8c86167 to
1a0a0fe
Compare
1a0a0fe to
b648e53
Compare
9a6c619 to
f19f5ed
Compare
|
Great job! No new security vulnerabilities introduced in this pull request |
|
Claude finished @renovate[bot]'s task —— View job PR Review: Jest Major Version UpdateSummaryThis PR attempts to update FindingsFinding 1: ❌ Peer dependency conflict blocks the update - Conflict DetailsThe Renovate error message shows: Jest is not directly declared in package.json - it's provided indirectly through Finding 2: ❌ Multiple dependencies need coordinated updates - upgrading jest-preset-angular requires upgrading Jest, ts-jest, and potentially @nx/jest (package.json:138, package.json:174) Breaking Changes in jest-preset-angular 15.0.0According to the release notes:
Finding 3: Finding 4: 💭 Should ts-jest be updated alongside? - Currently at 29.4.5, may need update to support Jest 30 (package.json:138) Finding 5: 💭 What is the strategy for @nx/jest? - Need to verify if Nx 21.3.11 supports Jest 30, or if Nx also needs updating (package.json:174) RecommendationsOption 1: Complete Jest 30 Migration (Recommended)
Option 2: Close This PR
Option 3: Partial Update (Not Recommended)
Test Plan Concern💭 This PR lacks a test plan. For a major dependency update affecting the entire test infrastructure, the PR should document:
Verdict: This PR cannot be merged as-is due to the peer dependency conflict. A broader Jest 30 migration effort is needed, potentially coordinated with Nx updates. |
18a8e3d to
aa32367
Compare
| "jest-junit": "16.0.0", | ||
| "jest-mock-extended": "3.0.7", | ||
| "jest-preset-angular": "14.6.1", | ||
| "jest-preset-angular": "15.0.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ This update requires Jest 30.x, but the project currently uses Jest 29.7.0 (provided by @nx/[email protected]). This creates a peer dependency conflict that blocks installation.
To proceed with this update, you'll need to:
- Upgrade Jest to version 30.x
- Update
ts-jestto a Jest 30-compatible version - Add
jest-environment-jsdomas an explicit peer dependency - Verify
@nx/jestcompatibility with Jest 30
Consider whether this should be part of a coordinated Jest 30 migration effort rather than an isolated update.
| "@types/firefox-webext-browser": "120.0.4", | ||
| "@types/inquirer": "8.2.10", | ||
| "@types/jest": "29.5.14", | ||
| "@types/jest": "30.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@types/[email protected] while using Jest 29.7.0 creates a version mismatch. The type definitions are for Jest 30 APIs, which may not perfectly align with the Jest 29 runtime.
This could lead to:
- Type checking passing for APIs that don't exist in Jest 29
- Missing type errors for deprecated Jest 29 patterns
- IntelliSense suggesting Jest 30 features that aren't available
Consider keeping @types/[email protected] until the full Jest 30 migration is complete.
ae4803e to
9b64532
Compare
9b64532 to
c4d9fc1
Compare
|
We cannot update to jest 30 until the following dependency updates have happened: Update @nx/jest to a version that supports Jest 30 (check Nx compatibility) |

This PR contains the following updates:
29.5.14->30.0.014.6.1->15.0.3Release Notes
thymikee/jest-preset-angular (jest-preset-angular)
v15.0.3Compare Source
Bug Fixes
processWithEsbuildtransform option (6779107)v15.0.2Compare Source
Bug Fixes
dynamic-importsupport flag into esbuild invocation (#3369) (fa25060), closes #3368v15.0.1Compare Source
Bug Fixes
jest-environment-jsdom(#3333) (d3e899b), closes #3331v15.0.0Compare Source
Bug Fixes
id="root{n}"should be removed (a6b908f)Features
testEnvironmentvia preset creator functions (80c95e8)Code Refactoring
jest-environment-jsdomas peer dependency (f9e2b70)jsdom<22 (da9cb15)typescript<5.4 (873ab73)defaultsanddefaults-esmpresets (94dd3b1)setup-jestfiles (6bf89a4)ngcc(35819c9)BREAKING CHANGES
JSDOMis 26ng-jest-resolveris no longer needed for Jest 30 therefore it was removedjsdomdep is now MANDATORY peer dependency. Users are required to installjsdomexplicitlyjest-environment-jsdomis now MANDATORY dependency. Users are required to installjest-environment-jsdomexplicitly-uJest CLI option. Since this change only removes the rootid, it shouldn't affect the quality of snapshots in general.NodeJsversions are^18.19.1 || ^20.11.1 || >=22.0.0.jsdomis 22TypeScriptis 5.5 following the support version from Angular 18ngccis not required for Angular 16+ projectcreateCjsPresetas a replacement fordefaultspresetcreateEsmPresetas a replacement fordefaults-esmpresetsetupZoneTestEnvas a replacement for zone test environment setupsetupZonelessTestEnvas a replacement for zoneless test environment setup14.6.2 (2025-10-17)
Bug Fixes
processWithEsbuildtransform option (6779107)14.6.1 (2025-07-21)
Bug Fixes
@angular/common/localesto CJS preset #3190 (4234520), closes #318214.6.0 (2025-06-02)
Features
14.5.5 (2025-04-15)
Bug Fixes
presetssubpath (9100baf)v14.6.2Compare Source
Bug Fixes
id="root{n}"should be removed (a6b908f)Features
testEnvironmentvia preset creator functions (80c95e8)Code Refactoring
jest-environment-jsdomas peer dependency (f9e2b70)jsdom<22 (da9cb15)typescript<5.4 (873ab73)defaultsanddefaults-esmpresets (94dd3b1)setup-jestfiles (6bf89a4)ngcc(35819c9)BREAKING CHANGES
JSDOMis 26ng-jest-resolveris no longer needed for Jest 30 therefore it was removedjsdomdep is now MANDATORY peer dependency. Users are required to installjsdomexplicitlyjest-environment-jsdomis now MANDATORY dependency. Users are required to installjest-environment-jsdomexplicitly-uJest CLI option. Since this change only removes the rootid, it shouldn't affect the quality of snapshots in general.NodeJsversions are^18.19.1 || ^20.11.1 || >=22.0.0.jsdomis 22TypeScriptis 5.5 following the support version from Angular 18ngccis not required for Angular 16+ projectcreateCjsPresetas a replacement fordefaultspresetcreateEsmPresetas a replacement fordefaults-esmpresetsetupZoneTestEnvas a replacement for zone test environment setupsetupZonelessTestEnvas a replacement for zoneless test environment setup14.6.2 (2025-10-17)
Bug Fixes
processWithEsbuildtransform option (6779107)14.6.1 (2025-07-21)
Bug Fixes
@angular/common/localesto CJS preset #3190 (4234520), closes #318214.6.0 (2025-06-02)
Features
14.5.5 (2025-04-15)
Bug Fixes
presetssubpath (9100baf)Configuration
📅 Schedule: Branch creation - "every 2nd week starting on the 2 week of the year before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.