Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Jun 23, 2025

This PR contains the following updates:

Package Change Age Confidence
jest-mock-extended 3.0.7 -> 4.0.0 age confidence

Release Notes

marchaos/jest-mock-extended (jest-mock-extended)

v4.0.0

Compare Source

Upgrade to jest 30


Configuration

📅 Schedule: Branch creation - "every 2nd week starting on the 2 week of the year before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested a review from a team June 23, 2025 03:59
@bitwarden-bot bitwarden-bot changed the title [deps] SM: Update jest-mock-extended to v4 [SM-1506] [deps] SM: Update jest-mock-extended to v4 Jun 23, 2025
@bitwarden-bot
Copy link

Internal tracking:

@renovate renovate bot changed the title [SM-1506] [deps] SM: Update jest-mock-extended to v4 [deps] SM: Update jest-mock-extended to v4 Jun 23, 2025
@renovate renovate bot force-pushed the renovate/jest-mock-extended-4.x branch 2 times, most recently from f764a3c to 1bb0587 Compare August 13, 2025 13:07
@renovate renovate bot force-pushed the renovate/jest-mock-extended-4.x branch from 1bb0587 to 5c9d6cf Compare August 19, 2025 12:10
@renovate renovate bot force-pushed the renovate/jest-mock-extended-4.x branch from 5c9d6cf to 0b5c8e9 Compare August 31, 2025 11:45
@renovate renovate bot force-pushed the renovate/jest-mock-extended-4.x branch from 0b5c8e9 to 0ca03ae Compare September 25, 2025 14:15
@renovate renovate bot force-pushed the renovate/jest-mock-extended-4.x branch 2 times, most recently from ba29ad2 to 3ec7c44 Compare October 22, 2025 20:20
Copy link
Contributor

@cd-bitwarden cd-bitwarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested everything locally, this looks good

@claude
Copy link

claude bot commented Oct 28, 2025

Claude finished @renovate[bot]'s task —— View job


Review Complete

Summary

This PR attempts to upgrade jest-mock-extended from v3.0.7 to v4.0.0. However, this upgrade is incompatible with the project's current Jest configuration.


Findings

Finding 1: Incompatible Jest version (❌ Major - blocking)

Issue: jest-mock-extended v4.0.0 requires Jest 30, but this project currently uses Jest 29.

Evidence:

  • Current jest-preset-angular: 14.6.1 (requires Jest ^29.0.0)
  • jest-mock-extended v4.0.0 peer dependencies require Jest ^30.0.0
  • This exact upgrade was previously attempted and reverted in commit b3b6df8859 with the message: "The update to jest-mock-extended v4.0.0 was incompatible with the project's current Jest 29 installation"

Impact: This PR will cause the same compatibility issues that led to the previous revert, including npm installation failures and test failures.

Resolution Required: This PR should not be merged until Jest is upgraded to v30. I can see there's work in progress on a "SM-Jest" branch that upgrades jest-preset-angular to v15.0.3 (which supports Jest 30). This jest-mock-extended upgrade should wait for that Jest 30 upgrade to be completed and merged first.


Finding 2: PR lacks proper context (💭 Inquiry)

The PR description doesn't mention:

  • The Jest version compatibility requirement
  • The previous revert (commit b3b6df8859)
  • The dependency on the Jest 30 upgrade effort

Recommendation: Update the PR description to note that this depends on the Jest 30 upgrade being completed first, or close this PR until Jest 30 is available in main.


Recommendation

Do not merge this PR until:

  1. Jest is upgraded to v30 in the main branch
  2. The SM-Jest branch (or equivalent) with jest-preset-angular v15+ is merged
  3. This PR is rebased on top of the Jest 30 upgrade

The human reviewer (@cd-bitwarden) approved this after testing locally, which suggests the compatibility issue may not be immediately obvious in local testing. However, the previous CI failures and revert demonstrate this will cause issues in production.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 28, 2025

Logo
Checkmarx One – Scan Summary & Details35aa7c1b-f2f4-4ee1-96a4-185ae1dbd51a

Great job! No new security vulnerabilities introduced in this pull request

@cd-bitwarden cd-bitwarden enabled auto-merge (squash) November 4, 2025 18:01
@renovate renovate bot force-pushed the renovate/jest-mock-extended-4.x branch from f5cefbf to 3139d0b Compare November 19, 2025 18:02
"jest-diff": "30.2.0",
"jest-junit": "16.0.0",
"jest-mock-extended": "3.0.7",
"jest-mock-extended": "4.0.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This upgrade to v4.0.0 requires Jest 30, but the project currently uses Jest 29 (via jest-preset-angular 14.6.1).

This exact change was previously reverted in commit b3b6df8859 due to compatibility issues. The upgrade should wait until the Jest 30 migration (SM-Jest branch with jest-preset-angular v15+) is merged to main.

@cd-bitwarden
Copy link
Contributor

Placing on hold until we can upgrade to Jest 30, it is required for this PR.

auto-merge was automatically disabled November 20, 2025 18:53

Pull request was closed

@renovate
Copy link
Contributor Author

renovate bot commented Nov 20, 2025

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 4.x releases. But if you manually upgrade to 4.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate renovate bot deleted the renovate/jest-mock-extended-4.x branch November 20, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants