-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[deps] SM: Update jest-mock-extended to v4 #15294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Internal tracking:
|
f764a3c to
1bb0587
Compare
1bb0587 to
5c9d6cf
Compare
5c9d6cf to
0b5c8e9
Compare
0b5c8e9 to
0ca03ae
Compare
ba29ad2 to
3ec7c44
Compare
cd-bitwarden
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested everything locally, this looks good
|
Claude finished @renovate[bot]'s task —— View job Review CompleteSummaryThis PR attempts to upgrade FindingsFinding 1: Incompatible Jest version (❌ Major - blocking)Issue: jest-mock-extended v4.0.0 requires Jest 30, but this project currently uses Jest 29. Evidence:
Impact: This PR will cause the same compatibility issues that led to the previous revert, including npm installation failures and test failures. Resolution Required: This PR should not be merged until Jest is upgraded to v30. I can see there's work in progress on a "SM-Jest" branch that upgrades jest-preset-angular to v15.0.3 (which supports Jest 30). This jest-mock-extended upgrade should wait for that Jest 30 upgrade to be completed and merged first. Finding 2: PR lacks proper context (💭 Inquiry)The PR description doesn't mention:
Recommendation: Update the PR description to note that this depends on the Jest 30 upgrade being completed first, or close this PR until Jest 30 is available in main. RecommendationDo not merge this PR until:
The human reviewer (@cd-bitwarden) approved this after testing locally, which suggests the compatibility issue may not be immediately obvious in local testing. However, the previous CI failures and revert demonstrate this will cause issues in production. |
|
Great job! No new security vulnerabilities introduced in this pull request |
f5cefbf to
3139d0b
Compare
| "jest-diff": "30.2.0", | ||
| "jest-junit": "16.0.0", | ||
| "jest-mock-extended": "3.0.7", | ||
| "jest-mock-extended": "4.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This upgrade to v4.0.0 requires Jest 30, but the project currently uses Jest 29 (via jest-preset-angular 14.6.1).
This exact change was previously reverted in commit b3b6df8859 due to compatibility issues. The upgrade should wait until the Jest 30 migration (SM-Jest branch with jest-preset-angular v15+) is merged to main.
|
Placing on hold until we can upgrade to Jest 30, it is required for this PR. |
Pull request was closed
Renovate Ignore NotificationBecause you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR. |

This PR contains the following updates:
3.0.7->4.0.0Release Notes
marchaos/jest-mock-extended (jest-mock-extended)
v4.0.0Compare Source
Upgrade to jest 30
Configuration
📅 Schedule: Branch creation - "every 2nd week starting on the 2 week of the year before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.