Skip to content

[PM-21867] Fix send rotation broken due to incorrect types #14874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2025

Conversation

quexten
Copy link
Contributor

@quexten quexten commented May 22, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-21867

📔 Objective

Despite it's name; send.key is not a key. We had documented this in a few other places, but not yet in the key-rotation code, so it was incorrectly assumed to be a key. The new validation on unwrapSymmetricKey / wrapSymmetricKey assumes a symmetric cryptokey to be passed in, which only accepts 32 / 64 / >64 byte keys which made this fail. (In any case, it is the incorrect primitive and would otherwise have lead to issues later on when switching out the implementation of wrapSymmetricKey).

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@quexten quexten changed the title Fix send rotation broken due to incorrect types [PM-21867] Fix send rotation broken due to incorrect types May 22, 2025
@quexten quexten marked this pull request as ready for review May 22, 2025 08:23
@quexten quexten requested a review from a team as a code owner May 22, 2025 08:23
Copy link

codecov bot commented May 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.41%. Comparing base (0555d82) to head (6c8ff89).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14874   +/-   ##
=======================================
  Coverage   36.41%   36.41%           
=======================================
  Files        3212     3212           
  Lines       93279    93279           
  Branches    16840    16840           
=======================================
  Hits        33966    33966           
  Misses      56845    56845           
  Partials     2468     2468           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details9b8a22d9-bff2-4996-bd5e-3182a18602c9

Great job, no security vulnerabilities found in this Pull Request

@quexten quexten merged commit 068c63e into main May 22, 2025
100 checks passed
@quexten quexten deleted the km/pm-21867/fix-send-key-rotation branch May 22, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants