[PM-21882] Lit Components Cleanup

[jprusik]

🎟️ Tracking

PM-21882

📔 Objective

Clean up the Lit component stories a bit

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[jprusik]

The inferred diff here is a little weird; this is actually a removal of the cipher-item story and a rename of the item-row story (and it's components)

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 36.42%. Comparing base (f0b2551) to head (d352a6b).
Report is 7 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...utofill/content/components/rows/cipher-item-row.ts	0.00%	7 Missing ⚠️
...ts/lit-stories/rows/cipher-item-row.lit-stories.ts	0.00%	4 Missing ⚠️
...ponents/lit-stories/rows/button-row.lit-stories.ts	0.00%	2 Missing ⚠️
...c/autofill/content/components/notification/body.ts	0.00%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #14872   +/-   ##
=======================================
  Coverage   36.42%   36.42%           
=======================================
  Files        3212     3207    -5     
  Lines       93280    93247   -33     
  Branches    16840    16840           
=======================================
- Hits        33973    33966    -7     
+ Misses      56839    56813   -26     
  Partials     2468     2468           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

Checkmarx One – Scan Summary & Details – 003aa3f5-6536-47a3-83f4-4b5612be9b10

Great job, no security vulnerabilities found in this Pull Request

[dan-livefront]

These changes make sense.

Non blocking nit: would it make sense to wrap rows in a container to restrict width span?

[jprusik]

These changes make sense.

Non blocking nit: would it make sense to wrap rows in a container to restrict width span?

I had considered that, but being able to see components natural behaviour in isolation is useful too (does the component have a native "size", or does it take over the space of it's container?) and instructional on how it may or may not need to be handled in different contexts. In any case, you can see these cases used in composed situations in other stories, so it didn't feel like a critical need at this point.

That said, we do that in some stories (see: Icons), so I could go either way on that, I think. For now I opted to leave it alone and we can revisit in the future.