Skip to content

PM-21651 [For Automation Purposes] add test IDs to notification bar #14863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dan-livefront
Copy link
Collaborator

@dan-livefront dan-livefront commented May 21, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-21651

📔 Objective

  • Save Login Notification
  • Save to vault drop down
  • Save to vault drop down items
  • Login updated notification
  • Login saved notification
  • Select folder drop down
  • Select folder drop down items

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@dan-livefront dan-livefront self-assigned this May 21, 2025
Copy link
Contributor

github-actions bot commented May 21, 2025

Logo
Checkmarx One – Scan Summary & Details188f77ed-131b-4c4b-9cc3-3339ee9f875b

New Issues (5)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
MEDIUM CVE-2024-53382 Npm-prismjs-1.29.0
detailsRecommended version: 1.30.0
Description: Prism (aka PrismJS) allows DOM Clobbering (with resultant XSS for untrusted input that contains HTML but does not directly contain JavaScript), bec...
Attack Vector: NETWORK
Attack Complexity: HIGH

ID: WlT9NvuDINN%2B2DsE6tS2VJSR555MXnMBhJBTGNVXJvg%3D
Vulnerable Package
MEDIUM CVE-2025-32996 Npm-http-proxy-middleware-2.0.7
detailsRecommended version: 2.0.9
Description: In http-proxy-middleware v1.3.0 through v2.0.7 and v3.x through v3.0.3, "writeBody" function can be called twice because "else if" is not used.
Attack Vector: NETWORK
Attack Complexity: HIGH

ID: cjl4duGotxrTGDDcA4cP8BI93iz19VlkYHoAjMkxwmo%3D
Vulnerable Package
MEDIUM CVE-2025-32997 Npm-http-proxy-middleware-2.0.7
detailsRecommended version: 2.0.9
Description: In http-proxy-middleware versions 1.3.0 through 2.0.8 and 3.x through 3.0.4, the "fixRequestBody" function proceeds even if "bodyParser" has failed.
Attack Vector: NETWORK
Attack Complexity: HIGH

ID: 6yDLgu1zIkYGhnN73xvxYmoeOlefNA3gWaXW5ULlGb4%3D
Vulnerable Package
MEDIUM Insecure_Storage_of_Sensitive_Data /apps/cli/src/commands/get.command.ts: 380
detailsThe application takes sensitive, personal data cipher, found at line 380 of /apps/cli/src/commands/get.command.ts, and stores it in an unprotecte...
ID: 8GhlX7vjBXgkNFKWJYq5dIx96Ks%3D
Attack Vector
MEDIUM Insecure_Storage_of_Sensitive_Data /apps/cli/src/commands/get.command.ts: 330
detailsThe application takes sensitive, personal data cipher, found at line 330 of /apps/cli/src/commands/get.command.ts, and stores it in an unprotecte...
ID: VEq1%2FxnDIBXo06ty3VnIwG1DF80%3D
Attack Vector
Fixed Issues (2)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
MEDIUM Insecure_Storage_of_Sensitive_Data /apps/cli/src/commands/get.command.ts: 378
MEDIUM Insecure_Storage_of_Sensitive_Data /apps/cli/src/commands/get.command.ts: 377

Copy link

codecov bot commented May 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 36.41%. Comparing base (d7c936e) to head (3b76599).
Report is 15 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/browser/src/autofill/notification/bar.ts 0.00% 5 Missing ⚠️
...nt/components/option-selection/option-selection.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14863      +/-   ##
==========================================
- Coverage   36.42%   36.41%   -0.01%     
==========================================
  Files        3212     3212              
  Lines       93235    93270      +35     
  Branches    16826    16837      +11     
==========================================
+ Hits        33960    33965       +5     
- Misses      56812    56837      +25     
- Partials     2463     2468       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dan-livefront dan-livefront marked this pull request as ready for review May 21, 2025 16:15
@dan-livefront dan-livefront requested a review from a team as a code owner May 21, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant