[PM-21724] - add safari and firefox to list of potential browser vendors #14857
+15
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New Issues (5)Checkmarx found the following issues in this Pull Request
Fixed Issues (2)Great job! The following issues were fixed in this Pull Request
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #14857 +/- ##
==========================================
- Coverage 36.49% 36.33% -0.16%
==========================================
Files 3200 3200
Lines 92679 93309 +630
Branches 16694 16858 +164
==========================================
+ Hits 33822 33904 +82
- Misses 56403 56969 +566
+ Partials 2454 2436 -18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nick-livefront
previously approved these changes
May 21, 2025
jprusik
requested changes
May 27, 2025
Comment on lines
336
to
350
| get browserClientVendorExtended() { | ||
| if (this.browserClientVendor !== BrowserClientVendors.Unknown) { | ||
| return this.browserClientVendor; | ||
| } | ||
| if (this.platformUtilsService.isFirefox()) { | ||
| return "Firefox"; | ||
| } | ||
| if (this.platformUtilsService.isSafari()) { | ||
| return "Safari"; | ||
| } | ||
| return this.i18nService.t("turnOffBrowserAutofill", this.browserClientVendor); | ||
| } | ||
|
|
||
| get spotlightButtonText() { | ||
| return this.i18nService.t("turnOffBrowserAutofill", this.browserClientVendorExtended); | ||
| } |
There was a problem hiding this comment.
How are we representing the case where the client is Unknown now?
Even if our logic currently covers every known vendor case, could we have a fallback for unexpected cases? Otherwise you risk concatenating "undefined" into the string, no?
Suggested change
| get browserClientVendorExtended() { | |
| if (this.browserClientVendor !== BrowserClientVendors.Unknown) { | |
| return this.browserClientVendor; | |
| } | |
| if (this.platformUtilsService.isFirefox()) { | |
| return "Firefox"; | |
| } | |
| if (this.platformUtilsService.isSafari()) { | |
| return "Safari"; | |
| } | |
| return this.i18nService.t("turnOffBrowserAutofill", this.browserClientVendor); | |
| } | |
| get spotlightButtonText() { | |
| return this.i18nService.t("turnOffBrowserAutofill", this.browserClientVendorExtended); | |
| } | |
| get browserClientVendorExtended() { | |
| if (this.browserClientVendor !== BrowserClientVendors.Unknown) { | |
| return this.browserClientVendor; | |
| } | |
| if (this.platformUtilsService.isFirefox()) { | |
| return "Firefox"; | |
| } | |
| if (this.platformUtilsService.isSafari()) { | |
| return "Safari"; | |
| } | |
| return BrowserClientVendors.Unknown; | |
| } | |
| get spotlightButtonText() { | |
| if (this.browserClientVendorExtended === BrowserClientVendors.Unknown) { | |
| return this.i18nService.t("turnOffAutofill"); | |
| } | |
| return this.i18nService.t("turnOffBrowserAutofill", this.browserClientVendorExtended); | |
| } |
There was a problem hiding this comment.
@jprusik Ah yes ofc. Thanks for pointing this out. I've pushed an update with a small addition to your suggestion.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-21724
📔 Objective
This PR adds safari and firefox to the list of potential browser vendors for the autofill spotlight nudge.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes