Skip to content

PM-16653 remove idp auto submit login step 1 #14847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

dan-livefront
Copy link
Collaborator

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-16653

📔 Objective

remove idp auto submit login step 1

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@dan-livefront dan-livefront self-assigned this May 19, 2025
Copy link
Contributor

github-actions bot commented May 19, 2025

Logo
Checkmarx One – Scan Summary & Detailsfdba2888-ae54-4da4-98c9-4400d2d69e9d

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented May 20, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 36.42%. Comparing base (1c4d851) to head (a31f337).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
bitwarden_license/bit-web/src/app/app.component.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14847   +/-   ##
=======================================
  Coverage   36.41%   36.42%           
=======================================
  Files        3212     3212           
  Lines       93265    93256    -9     
  Branches    16833    16830    -3     
=======================================
+ Hits        33967    33969    +2     
+ Misses      56831    56820   -11     
  Partials     2467     2467           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dan-livefront dan-livefront marked this pull request as ready for review May 20, 2025 18:36
@dan-livefront dan-livefront requested a review from a team as a code owner May 20, 2025 18:36
jprusik
jprusik previously approved these changes May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants