-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[CL-277] fix bitA11yGrid
inside virtual scroll viewport
#14842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
New Issues (3)Checkmarx found the following issues in this Pull Request
Fixed Issues (1)Great job! The following issues were fixed in this Pull Request
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #14842 +/- ##
==========================================
- Coverage 36.57% 36.42% -0.16%
==========================================
Files 3190 3212 +22
Lines 92182 93288 +1106
Branches 16534 16834 +300
==========================================
+ Hits 33720 33982 +262
- Misses 56065 56839 +774
- Partials 2397 2467 +70 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bit-item-group
keyboard navbitA11yGrid
inside virtual scroll viewport
|
🎟️ Tracking
https://bitwarden.atlassian.net/browse/CL-277
📔 Objective
Make
bitA11yGrid
work within a virtual scroll viewport. This will allow us to use arrow-key navigation inbit-item-group
(now) andbit-table
(in a future PR).📸 Screenshots
See Storybook > Item > Virtual Scrolling
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes