Skip to content

Commit 1e9b416

Browse files
committed
Merge branch 'main' into km/new-pin-service-interface
2 parents ac4da36 + 601c1cc commit 1e9b416

File tree

319 files changed

+11083
-1036
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

319 files changed

+11083
-1036
lines changed

.github/renovate.json5

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -324,6 +324,7 @@
324324
"storybook",
325325
"tailwindcss",
326326
"zone.js",
327+
"@tailwindcss/container-queries",
327328
],
328329
description: "UI Foundation owned dependencies",
329330
commitMessagePrefix: "[deps] UI Foundation:",

.github/workflows/publish-cli.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ jobs:
119119
uses: bitwarden/gh-actions/azure-logout@main
120120

121121
- name: Install Snap
122-
uses: samuelmeuli/action-snapcraft@d33c176a9b784876d966f80fb1b461808edc0641 # v2.1.1
122+
uses: samuelmeuli/action-snapcraft@fceeb3c308e76f3487e72ef608618de625fb7fe8 # v3.0.1
123123

124124
- name: Download artifacts
125125
run: wget https://github.com/bitwarden/clients/releases/download/cli-v${{ env._PKG_VERSION }}/bw_${{ env._PKG_VERSION }}_amd64.snap

.github/workflows/publish-desktop.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ jobs:
233233
uses: bitwarden/gh-actions/azure-logout@main
234234

235235
- name: Install Snap
236-
uses: samuelmeuli/action-snapcraft@d33c176a9b784876d966f80fb1b461808edc0641 # v2.1.1
236+
uses: samuelmeuli/action-snapcraft@fceeb3c308e76f3487e72ef608618de625fb7fe8 # v3.0.1
237237

238238
- name: Setup
239239
run: mkdir dist

.github/workflows/review-code.yml

Lines changed: 18 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -84,16 +84,18 @@ jobs:
8484
8585
- name: Review with Claude Code
8686
if: steps.check_changes.outputs.vault_team_changes == 'true'
87-
uses: anthropics/claude-code-action@a5528eec7426a4f0c9c1ac96018daa53ebd05bc4 # v1.0.7
87+
uses: anthropics/claude-code-action@ac1a3207f3f00b4a37e2f3a6f0935733c7c64651 # v1.0.11
8888
with:
8989
anthropic_api_key: ${{ secrets.ANTHROPIC_API_KEY }}
9090
track_progress: true
91+
use_sticky_comment: true
9192
prompt: |
9293
REPO: ${{ github.repository }}
9394
PR NUMBER: ${{ github.event.pull_request.number }}
9495
TITLE: ${{ github.event.pull_request.title }}
9596
BODY: ${{ github.event.pull_request.body }}
9697
AUTHOR: ${{ github.event.pull_request.user.login }}
98+
COMMIT: ${{ github.event.pull_request.head.sha }}
9799
98100
Please review this pull request with a focus on:
99101
- Code quality and best practices
@@ -103,7 +105,20 @@ jobs:
103105
104106
Note: The PR branch is already checked out in the current working directory.
105107
106-
Provide detailed feedback using inline comments for specific issues.
108+
Provide a comprehensive review including:
109+
- Summary of changes since last review
110+
- Critical issues found (be thorough)
111+
- Suggested improvements (be thorough)
112+
- Good practices observed (be concise - list only the most notable items without elaboration)
113+
- Action items for the author
114+
- Leverage collapsible <details> sections where appropriate for lengthy explanations or code snippets to enhance human readability
115+
116+
When reviewing subsequent commits:
117+
- Track status of previously identified issues (fixed/unfixed/reopened)
118+
- Identify NEW problems introduced since last review
119+
- Note if fixes introduced new issues
120+
121+
IMPORTANT: Be comprehensive about issues and improvements. For good practices, be brief - just note what was done well without explaining why or praising excessively.
107122
108123
claude_args: |
109-
--allowedTools "mcp__github_inline_comment__create_inline_comment,Bash(gh pr comment:*),Bash(gh pr diff:*),Bash(gh pr view:*)"
124+
--allowedTools "mcp__github_comment__update_claude_comment,mcp__github_inline_comment__create_inline_comment,Bash(gh pr diff:*),Bash(gh pr view:*)"

.storybook/preview.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ setCompodocJson(docJson);
88

99
const wrapperDecorator = componentWrapperDecorator((story) => {
1010
return /*html*/ `
11-
<div class="tw-bg-background tw-px-5 tw-py-10">
11+
<div class="tw-bg-background tw-px-5 tw-py-10 tw-@container">
1212
${story}
1313
</div>
1414
`;

CLAUDE.md

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,13 @@
11
# Bitwarden Clients - Claude Code Configuration
22

3+
## Project Context Files
4+
5+
**Read these files before reviewing to ensure that you fully understand the project and contributing guidelines**
6+
7+
1. @README.md
8+
2. @CONTRIBUTING.md
9+
3. @.github/PULL_REQUEST_TEMPLATE.md
10+
311
## Critical Rules
412

513
- **NEVER** use code regions: If complexity suggests regions, refactor for better readability
@@ -8,7 +16,7 @@
816

917
- **NEVER** send unencrypted vault data to API services
1018

11-
- **NEVER** commit secrets, credentials, or sensitive information. Follow the guidelines in `SECURITY.md`.
19+
- **NEVER** commit secrets, credentials, or sensitive information.
1220

1321
- **NEVER** log decrypted data, encryption keys, or PII
1422
- No vault data in error messages or console logs
@@ -88,3 +96,13 @@ enum CipherType {
8896
```
8997

9098
Example: `/libs/common/src/vault/enums/cipher-type.ts`
99+
100+
## References
101+
102+
- [Web Clients Architecture](https://contributing.bitwarden.com/architecture/clients)
103+
- [Architectural Decision Records (ADRs)](https://contributing.bitwarden.com/architecture/adr/)
104+
- [Contributing Guide](https://contributing.bitwarden.com/)
105+
- [Web Clients Setup Guide](https://contributing.bitwarden.com/getting-started/clients/)
106+
- [Code Style](https://contributing.bitwarden.com/contributing/code-style/)
107+
- [Security Whitepaper](https://bitwarden.com/help/bitwarden-security-white-paper/)
108+
- [Security Definitions](https://contributing.bitwarden.com/architecture/security/definitions)

apps/browser/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@bitwarden/browser",
3-
"version": "2025.10.0",
3+
"version": "2025.10.1",
44
"scripts": {
55
"build": "npm run build:chrome",
66
"build:bit": "npm run build:bit:chrome",

apps/browser/src/_locales/ar/messages.json

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1548,6 +1548,15 @@
15481548
"readSecurityKey": {
15491549
"message": "قراءة مفتاح الأمان"
15501550
},
1551+
"readingPasskeyLoading": {
1552+
"message": "Reading passkey..."
1553+
},
1554+
"passkeyAuthenticationFailed": {
1555+
"message": "Passkey authentication failed"
1556+
},
1557+
"useADifferentLogInMethod": {
1558+
"message": "Use a different log in method"
1559+
},
15511560
"awaitingSecurityKeyInteraction": {
15521561
"message": "في انتظار التفاعل مع مفتاح الأمن..."
15531562
},

apps/browser/src/_locales/az/messages.json

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -551,11 +551,11 @@
551551
"message": "Axtarışı sıfırla"
552552
},
553553
"archiveNoun": {
554-
"message": "Archive",
554+
"message": "Arxiv",
555555
"description": "Noun"
556556
},
557557
"archiveVerb": {
558-
"message": "Archive",
558+
"message": "Arxivlə",
559559
"description": "Verb"
560560
},
561561
"unarchive": {
@@ -734,7 +734,7 @@
734734
"message": "Yararsız ana parol"
735735
},
736736
"invalidMasterPasswordConfirmEmailAndHost": {
737-
"message": "Invalid master password. Confirm your email is correct and your account was created on $HOST$.",
737+
"message": "Yararsız ana parol. E-poçtunuzun doğru olduğunu və hesabınızın $HOST$ üzərində yaradıldığını təsdiqləyin.",
738738
"placeholders": {
739739
"host": {
740740
"content": "$1",
@@ -1548,6 +1548,15 @@
15481548
"readSecurityKey": {
15491549
"message": "Güvənlik açarını oxu"
15501550
},
1551+
"readingPasskeyLoading": {
1552+
"message": "Keçid açarı oxunur..."
1553+
},
1554+
"passkeyAuthenticationFailed": {
1555+
"message": "Keçid açarı kimlik doğrulaması uğursuzdur"
1556+
},
1557+
"useADifferentLogInMethod": {
1558+
"message": "Fərqli bir giriş üsulu istifadə edin"
1559+
},
15511560
"awaitingSecurityKeyInteraction": {
15521561
"message": "Güvənlik açarı ilə əlaqə gözlənilir..."
15531562
},
@@ -3208,7 +3217,7 @@
32083217
}
32093218
},
32103219
"exportingOrganizationVaultFromPasswordManagerWithDataOwnershipDesc": {
3211-
"message": "Only the organization vault associated with $ORGANIZATION$ will be exported.",
3220+
"message": "Yalnız $ORGANIZATION$ ilə əlaqələndirilmiş təşkilat seyfi xaricə köçürüləcək.",
32123221
"placeholders": {
32133222
"organization": {
32143223
"content": "$1",
@@ -3217,7 +3226,7 @@
32173226
}
32183227
},
32193228
"exportingOrganizationVaultFromAdminConsoleWithDataOwnershipDesc": {
3220-
"message": "Only the organization vault associated with $ORGANIZATION$ will be exported. My items collections will not be included.",
3229+
"message": "Yalnız $ORGANIZATION$ ilə əlaqələndirilmiş təşkilat seyfi xaricə köçürüləcək. Element kolleksiyalarım daxil edilməyəcək.",
32213230
"placeholders": {
32223231
"organization": {
32233232
"content": "$1",

apps/browser/src/_locales/be/messages.json

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1548,6 +1548,15 @@
15481548
"readSecurityKey": {
15491549
"message": "Read security key"
15501550
},
1551+
"readingPasskeyLoading": {
1552+
"message": "Reading passkey..."
1553+
},
1554+
"passkeyAuthenticationFailed": {
1555+
"message": "Passkey authentication failed"
1556+
},
1557+
"useADifferentLogInMethod": {
1558+
"message": "Use a different log in method"
1559+
},
15511560
"awaitingSecurityKeyInteraction": {
15521561
"message": "Awaiting security key interaction..."
15531562
},

0 commit comments

Comments
 (0)